@schana I have turned the priority of this task to High as the Reading team is finishing up their tasks for running a survey for Research and it's important for us to run the survey as soon as everything is ready, including this task. If you are working on other tasks, please ping me and I'm happy to help you reprioritize.

Re the current task: do you have all the information you need to start working on it?

This story is currently not estimable as I need the following questions answered:

• The examples are unclear as they use a user id. Can you clarify what the query string parameter would look like?
• Would every survey use the same query string parameter or are some surveys expected to have more than one parameter?

@ellery in the description we say "To pre-fill the form with a users id, the url is modified to be". I /think/ what you mean by "user id" is "funnel token" or "page token", correct? We don't have other ways to identifying user.

@Jdlrobson

1. the query string parameter name should be configurable. The value of the parameter will always be the surveyInstanceToken.
2. there will only ever be one query string parameter that we need to add (i.e. surveyInstanceToken). I am not sure if the survey url will already have some query parameters set.

@Jdlrobson I also updated the description. Let me know if it needs more clarification.

Change 266797 had a related patch set uploaded (by Nschaaf):
Add URL parameter for external surveys

https://gerrit.wikimedia.org/r/266797

For the record: What I hear from @dr0ptp4kt is that this task is complete, but the code will not be merged until our ongoing discussion with Legal and Security are finalized.

Update - I think the code is still under review. Present advice is it's okay for engineers to +1 it if it is technically correct (i.e., an optional name-value pair can be appended => also means I think a query path separator [the ? mark] comes before it when this optional configuration is part of a given third party survey). Once the verbiage is solidified, though, the +2 can be applied if the +1s are there.

It's not optional as currently implemented. I'll fix that first thing Monday.

The URL parameter is now optional.

In T124511#1983516, @dr0ptp4kt wrote:

Update - I think the code is still under review. Present advice is it's okay for engineers to +1 it if it is technically correct (i.e., an optional name-value pair can be appended => also means I think a query path separator [the ? mark] comes before it when this optional configuration is part of a given third party survey). Once the verbiage is solidified, though, the +2 can be applied if the +1s are there.

@dr0ptp4kt to help me review this to the best of my ability is there a good reason why we wouldn't append this to all surveys?

If so, is there a good reason we make this so configurable? In the current patchset I can name the parameter anything so given a session id 5 I could use that cause confusion by configuring surveys like
http://surveys.wikimedia.org?id=50&token=5 and http://surveys.wikimedia.org?id=50&sessionid=5 and http://surveys.wikimedia.org?id=50&usersessionid=5
Wouldn't a simple boolean flag to send session id be enough?

i chatted with Adam in person and he told me that apparently the external surveys read this parameter and embed it in the form thus control over the name of the parameter is a necessary requirement which obviously changes this.

I will update my review with this in mind.

A few tweaks needed from @schana before we can wrap this up

Once the tweaks are in and acceptable to the code reviewers, code reviewers you've got the go ahead for +2 and merge-deploy the code.

Preferably this code is on the cluster the week of 8-February-2016 (again, assuming the code is good to go in time) (i.e., at the latest on Wikipedias by 11-February-2016).

Waiting on @schana

@schana's responded to @Jdlrobson's review.

I'd like @bmansurov or @phuedx to take a look at patch and +2
Note the patch is also on the dev branch so given the new release process we'll want to stick that back on master @schana

Change 266797 merged by jenkins-bot:
Add URL parameter for external surveys

https://gerrit.wikimedia.org/r/266797

Change 269351 had a related patch set uploaded (by Bmansurov):
Add URL parameter for external surveys

https://gerrit.wikimedia.org/r/269351

Change 269351 merged by jenkins-bot:
Add URL parameter for external surveys

https://gerrit.wikimedia.org/r/269351

Note the patch is also on the dev branch so given the new release process we'll want to stick that back on master @schana.

Done in 269351.