Page MenuHomePhabricator
Create Task
Maniphest T124571

"Paper clip" like icon required to show that a file is attached
Closed, ResolvedPublic
Actions

Description

As per T115860: Show image thumbnail in both steps of mw.ForeignStructuredUpload.BookletLayout we are trying to show thumbnails of images where available. When the file being uploaded is not an image we need to show a generic paper clip like icon.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SelectFileWidget: Show thumbnail when dropTarget is shownoojs/uimaster+243 -44
Icons: Add attachment icon to Mediawiki themeoojs/uimaster+21 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Prtksxna created this task.Jan 24 2016, 5:33 AM
• Prtksxna raised the priority of this task from to Needs Triage.
• Prtksxna updated the task description. (Show Details)
• Prtksxna added projects: Design, OOUI.
• Prtksxna added subscribers: • Prtksxna, matmarex, • violetto, • KHammerstein.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 24 2016, 5:33 AM
• Prtksxna added a comment.Jan 24 2016, 5:35 AM

Does such an icon already exist and is being used somewhere? I couldn't find anything in OOUI, but maybe I didn't look closely enough.

• Prtksxna added a parent task: T115860: Show image thumbnail in both steps of mw.ForeignStructuredUpload.BookletLayout.Jan 24 2016, 5:36 AM
MtDu subscribed.Jan 24 2016, 5:36 AM

@Prtksxna
There is a link icon that is being used in Echo. See https://phabricator.wikimedia.org/T121624

• Prtksxna added a comment.Jan 24 2016, 5:43 AM
In T124571#1959653, @MtDu wrote:

There is a link icon that is being used in Echo. See https://phabricator.wikimedia.org/T121624

Thanks for that link, but a link icon might not be the right thing to use here. In our case the widget needs to show that a file is attached rather than that a file is linked.

• Prtksxna added a subscriber: Pginer-WMF.Jan 26 2016, 11:54 PM
• violetto added a comment.Jan 27 2016, 1:15 AM

Yup we got one, it's not in the final folder. But I'll get that fixed soon.

• Prtksxna added a comment.Jan 27 2016, 1:25 AM

How about

attachment-ltr.svg700 BDownload
?

• violetto added a comment.Jan 27 2016, 1:27 AM

We have a pretty similar one here, but there are space and line thickness issues that I need to resolve. Give me until Friday to get this resolved, or is this pretty urgent?

• Prtksxna added a comment.Jan 27 2016, 2:08 AM

Friday is alright I guess, though sooner would be nice. Once you are done with the icon you can attach it here and I'll take care of the OOjs patch.

• Prtksxna added a comment.Jan 27 2016, 2:14 AM

@violetto, do you also happen to have the same icon for the Apex theme?

gerritbot subscribed.Jan 28 2016, 12:01 AM

Change 266950 had a related patch set uploaded (by Prtksxna):
Icons: Add attachment icon to Mediawiki theme

https://gerrit.wikimedia.org/r/266950

gerritbot added a project: Patch-For-Review.Jan 28 2016, 12:01 AM
• violetto added a comment.Jan 28 2016, 12:02 AM

A different icon?

• Prtksxna added a comment.Jan 28 2016, 12:05 AM

Just a placeholder patch. Its -1'd and awaiting your icon.

• violetto added a comment.Jan 28 2016, 12:07 AM
In T124571#1968414, @Prtksxna wrote:

@violetto, do you also happen to have the same icon for the Apex theme?

Were you asking for a different clip icon specifically for Apex? I only maintain one library. :/

• Prtksxna added a comment.Jan 28 2016, 12:11 AM
In T124571#1972178, @violetto wrote:
In T124571#1968414, @Prtksxna wrote:

@violetto, do you also happen to have the same icon for the Apex theme?

Were you asking for a different clip icon specifically for Apex? I only maintain one library. :/

I guess we can reuse the same one.

• violetto added a comment.Jan 28 2016, 12:37 AM

Ya, can.

• violetto added a comment.Jan 28 2016, 9:29 PM

uniE042 - clip.svg1 KBDownload

on Dropbox as well Design > + Assets > Icons > 4 Current > uniE042 - clip.svg

gerritbot added a comment.Feb 1 2016, 9:04 AM

Change 266950 abandoned by Prtksxna:
Icons: Add attachment icon to Mediawiki theme

Reason:
Adding the icon in I3f68bc instead.

https://gerrit.wikimedia.org/r/266950

gerritbot added a comment.Feb 1 2016, 9:06 AM

Change 265279 had a related patch set uploaded (by Prtksxna):
SelectFileWidget: Show thumbnail when dropTarget is shown

https://gerrit.wikimedia.org/r/265279

• Prtksxna claimed this task.Feb 1 2016, 9:08 AM
gerritbot added a comment.Feb 3 2016, 11:44 AM

Change 265279 merged by jenkins-bot:
SelectFileWidget: Show thumbnail when dropTarget is shown

https://gerrit.wikimedia.org/r/265279

• Prtksxna closed this task as Resolved.Feb 3 2016, 11:49 AM
• Prtksxna removed a project: Patch-For-Review.
• Prtksxna set Security to None.
Jdforrester-WMF added a project: OOjs-UI-next-release.Feb 3 2016, 7:31 PM
Jdforrester-WMF edited projects, added: MW-1.27-release (WMF-deploy-2016-02-16_(1.27.0-wmf.14)), OOUI (OOjs-UI-0.15.3); removed: OOjs-UI-next-release.Feb 10 2016, 2:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits