Page MenuHomePhabricator

"r" flag in ORES extension should be more noticeable
Closed, ResolvedPublic

Description

A simple "r" maybe not enough, something like unpatrolled sign (the red "!") is better, I suggest we change its color to red

Event Timeline

Ladsgroup claimed this task.
Ladsgroup raised the priority of this task from to Needs Triage.
Ladsgroup updated the task description. (Show Details)

Change 266167 had a related patch set uploaded (by Ladsgroup):
[WIP] Make "r" flag red

https://gerrit.wikimedia.org/r/266167

It's a better practice to not only use color to differentiate because color blindness users. What do you think about using an icon like this?

I'm thinking it like as if ORES "flagged" this edit as a warning for users to take another look. I use orange as a "warning," do you think an orange flag is a good representation for this?

Thanks for your feedback. I don't think making an icon would be feasible specially since other flags are not like this.
About making it orange please tell me if you mean something like:

pasted_file (1,366×768 px, 400 KB)

Compared to:

pasted_file (1,366×768 px, 400 KB)

(We also have "orangered" color but I haven't tested it yet)

Change 266167 merged by jenkins-bot:
Make "r" flag red, Also highlight the whole row

https://gerrit.wikimedia.org/r/266167

Not closing it right now, we need this for enhanced view too, It seems it doesn't work on this :)

Since EnhancedChangesList shows flags in a way better place (at first of lines instead of at the middle), I think we are good to go :)

Ladsgroup removed a project: Patch-For-Review.
Ladsgroup set Security to None.
Ladsgroup moved this task from Essential for MVP to Done on the MediaWiki-extensions-ORES board.