Page MenuHomePhabricator

Using the "#" keyboard shortcut (sequence), it's possible to input a list into image caption, which is mangled when turned back into wikitext
Closed, ResolvedPublic1 Estimated Story Points

Description

Using the "#" keyboard shortcut (sequence), it's possible to input a list into image caption, which is mangled when turned back into wikitext.


(Resulting page is http://en.wikipedia.beta.wmflabs.org/wiki/Caption_list?action=edit)

Lists are normally disabled in VE's image captions, presumably for this reason.

Neither Parsoid nor the PHP parser handle lists in image captions. Parsoid should probably output HTML tags in wikitext when faced with this problem? But until it does, we shouldn't allow lists there.

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Jdforrester-WMF set Security to None.

The captionTarget in the media dialog lists 'bullet' as a excluded command so this should work. Clearly the message is not getting through to the sequences code.

Change 266620 had a related patch set uploaded (by Esanders):
Sequences: Check command against surface's allowed commands

https://gerrit.wikimedia.org/r/266620

Change 266621 had a related patch set uploaded (by Esanders):
MediaDialog: Add missing indent commands to blacklist

https://gerrit.wikimedia.org/r/266621

Change 266620 merged by jenkins-bot:
Sequences: Check command against surface's allowed commands

https://gerrit.wikimedia.org/r/266620

Change 266621 merged by jenkins-bot:
MWTargetWidget: Add missing indent commands to blacklists

https://gerrit.wikimedia.org/r/266621

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.