⚓ T124650 On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit

	Subject	Repo	Branch	Lines +/-
	Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.	mediawiki/extensions/VisualEditor	master	+3 -0

Status	Subtype	Assigned	Task
Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Resolved		Krenair	T55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
Resolved		Krenair	T89060 VisualEditor is not the editor linked from the diff page
Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor
Open		None	T54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
Resolved		Krenair	T54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Resolved		Krenair	T124650 On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit

• Elitre created this task.Jan 25 2016, 12:18 PM

• Elitre raised the priority of this task from to Needs Triage.

• Elitre updated the task description. (Show Details)

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 25 2016, 12:18 PM

was the last editor you used VE?

Yes (and around the "last editor you used" bit, I'm finding a few things which look a bit weird and I'll try to report them separately).

Krenair renamed this task from "View source" tab actually launches the visual editor edit mode on test2.wikipedia.org to On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit.Jan 25 2016, 12:23 PM

Krenair set Security to None.

Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.

When preference for registered users is "always give me VE", clicking on the switch icon won't actually switch (the wikitext editor is shown for a few seconds, but then the page is still in VEdit mode).

For IPs who have VE as the last used editor, clicking on the switch icon will lead them to the the actual "View source for Main Page", which sets WT as the last editor for them with no ability to switch back, since the toolbar isn't loaded in this case (so I guess this could be generalized to "which kind of loading checks happen for protected pages", or something).

In T124650#1961631, @Elitre wrote:

When preference for registered users is "always give me VE", clicking on the switch icon won't actually switch (the wikitext editor is shown for a few seconds, but then the page is still in VEdit mode).

That's T124316: On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again.

Except for the (discarding changes) bit.

In T124650#1965696, @Elitre wrote:

Except for the (discarding changes) bit.

You made it happen with 'keep changes'? Or you weren't prompted to choose between keeping and discarding because you made no edits, and therefore the discard process was used regardless?

The latter AFAIK.

Krenair claimed this task.Jan 26 2016, 4:38 PM

Change 266522 had a related patch set uploaded (by Alex Monk):
Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.

https://gerrit.wikimedia.org/r/266522

gerritbot added a project: Patch-For-Review.Jan 26 2016, 4:38 PM

Jdforrester-WMF closed this task as Resolved.Jan 26 2016, 4:52 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.

Jdforrester-WMF edited a custom field.

Change 266522 merged by jenkins-bot:
Check user permissions for viewsource before loading VE on-load on action=edit/submit etc.

https://gerrit.wikimedia.org/r/266522

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 26 2016, 5:02 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jan 29 2016, 4:15 PM