Page MenuHomePhabricator
Create Task
Maniphest T124652

Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See https://test2.wikipedia.org/wiki/Abou_El_Hassan (tab link, clicking on it loads the wikitext editor) .
Works as intended instead when VE is the "last editor you used".

Details

SubjectRepoBranchLines +/-
Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changesmediawiki/extensions/FlaggedRevsmaster+4 -13
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"

Event Timeline

• Elitre created this task.Jan 25 2016, 12:32 PM
• Elitre raised the priority of this task from to Needs Triage.
• Elitre updated the task description. (Show Details)
• Elitre added a project: VisualEditor.
• Elitre subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 25 2016, 12:32 PM
• Elitre updated the task description. (Show Details)Jan 25 2016, 12:37 PM
• Elitre set Security to None.
Krenair added a project: VisualEditor-MediaWiki.Jan 26 2016, 2:19 AM
Krenair subscribed.
Krenair added a project: MediaWiki-extensions-FlaggedRevs.Jan 26 2016, 2:57 PM

That'd be FlaggedRevs overwriting it after us, based on FlaggablePageView::setViewTabs

Jdforrester-WMF added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Jan 26 2016, 4:10 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 26 2016, 8:26 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Krenair added a comment.Jan 27 2016, 3:32 PM

I'm not quite sure why FlaggedRevs is doing that... Usually it just ends up changing 'Edit' to 'Edit'...

Krenair assigned this task to aaron.Jan 27 2016, 11:49 PM

@aaron: Do you know why it's doing that?

aaron removed aaron as the assignee of this task.Jan 28 2016, 7:38 PM
Krenair added a subscriber: aaron.Jan 28 2016, 8:18 PM

@aaron: Is that a no, or..? I need your input as the FlaggedRevs guy :/

aaron added a comment.Jan 28 2016, 8:31 PM

It's not really my area atm. Also, my task assigners are normally myself and Ori :)

Jdforrester-WMF added a project: Blocked-on-Performance.Jan 28 2016, 9:14 PM
Krenair added a subscriber: ori.Jan 28 2016, 10:11 PM

@ori helped me track this down. It was committed in rEFLR98c87c5ccb1dbc40ac88c3fa2de1e269c901cc9d (rSVN25486, 2007-09-04) and seems like dead code as of rEFLR77e348785ae508f914e3a58987126c9cd9376712 (rSVN63829, 2010-03-16). (Apart from interfering with VE's modifications, that is.)

Krenair removed a project: Blocked-on-Performance.Jan 28 2016, 10:11 PM
gerritbot subscribed.Jan 28 2016, 10:18 PM

Change 267158 had a related patch set uploaded (by Alex Monk):
Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changes

https://gerrit.wikimedia.org/r/267158

gerritbot added a project: Patch-For-Review.Jan 28 2016, 10:18 PM
Krenair claimed this task.Jan 28 2016, 10:18 PM
gerritbot added a comment.Jan 29 2016, 1:12 AM

Change 267158 merged by jenkins-bot:
Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changes

https://gerrit.wikimedia.org/r/267158

Jdforrester-WMF closed this task as Resolved.Jan 29 2016, 1:16 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 29 2016, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL