⚓ T124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"

	Subject	Repo	Branch	Lines +/-
	Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changes	mediawiki/extensions/FlaggedRevs	master	+4 -13

• Elitre raised the priority of this task from to Needs Triage.

• Elitre updated the task description. (Show Details)

• Elitre subscribed.

• Elitre set Security to None.

Krenair subscribed.

That'd be FlaggedRevs overwriting it after us, based on FlaggablePageView::setViewTabs

Jdforrester-WMF triaged this task as Medium priority.Jan 26 2016, 8:26 PM

I'm not quite sure why FlaggedRevs is doing that... Usually it just ends up changing 'Edit' to 'Edit'...

@aaron: Do you know why it's doing that?

aaron removed aaron as the assignee of this task.Jan 28 2016, 7:38 PM

@aaron: Is that a no, or..? I need your input as the FlaggedRevs guy :/

It's not really my area atm. Also, my task assigners are normally myself and Ori :)

@ori helped me track this down. It was committed in rEFLR98c87c5ccb1dbc40ac88c3fa2de1e269c901cc9d (rSVN25486, 2007-09-04) and seems like dead code as of rEFLR77e348785ae508f914e3a58987126c9cd9376712 (rSVN63829, 2010-03-16). (Apart from interfering with VE's modifications, that is.)

Change 267158 had a related patch set uploaded (by Alex Monk):
Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changes

Change 267158 merged by jenkins-bot:
Delete old seemingly-obsolete code that was overwriting stuff VisualEditor changes

Jdforrester-WMF edited a custom field.

Status	Assigned	Task
		· · ·
Resolved	Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Resolved	Krenair	T124652 Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
		· · ·

Pages with pending changes show an "Edit" tab label even when they actually mean "Edit source"
Closed, ResolvedPublic1 Estimated Story Points
Actions