Page MenuHomePhabricator
Create Task
Maniphest T124708

Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. (We've figured out how to reproduce this everywhere.)
  2. Open a page in the visual editor. (Therefore, you are editing the whole page, not a section.)
  3. Make a change. Use the "Edit Source" tab at the top of the page to switch to the wikitext editor. Choose "Keep changes".
  4. Make a change. Use the "Edit" tab at the top of the page to switch to the visual editor. Choose "Keep changes".
  5. Make a change. Use the "Edit Source" tab at the top of the page to switch to the wikitext editor. Find that you are warned you will lose all your changes.
  6. Discover that all of your changes were lost – this time, but not any of the previous times.

This is consistently reproducible in 100% of attempts by following this exact process, both while logged in and while logged out/using a private browsing window, in multiple browsers and systems, but only if you use the tabs at the top of the page instead of the buttons in the toolbar.

Details

SubjectRepoBranchLines +/-
Run VE->WTE modification checks regardless of how the user got into VEmediawiki/extensions/VisualEditormaster+13 -13
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT265163 Create a system to encode best practices into editing experiences
 In ProgressTrizek-WMFT331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT124708 Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page

Event Timeline

• Whatamidoing-WMF created this task.Jan 25 2016, 8:55 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: VisualEditor.
• Whatamidoing-WMF subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 25 2016, 8:55 PM
Jdforrester-WMF renamed this task from Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch in Firefox 43 on Windows 10 (only) to Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch in Firefox 43 on Windows 10 (for one user).Jan 26 2016, 8:26 PM
Jdforrester-WMF changed the task status from Open to Stalled.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Jan 26 2016, 10:11 PM
• Whatamidoing-WMF renamed this task from Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch in Firefox 43 on Windows 10 (for one user) to Bi-directional switching (VE-WT-VE-WT) loses all changes on the third switch when using the Edit/Edit source tabs at the top of the page.Jan 27 2016, 7:31 PM
• Whatamidoing-WMF updated the task description. (Show Details)
• Elitre subscribed.Jan 27 2016, 7:35 PM
Jdforrester-WMF changed the task status from Stalled to Open.Jan 27 2016, 10:11 PM
Jdforrester-WMF assigned this task to Krenair.
Krenair added a comment.Jan 28 2016, 2:10 AM

Edit vs. edit source implies to me that this is only with multiple tabs, not the single edit tab?

gerritbot subscribed.Jan 28 2016, 2:32 AM

Change 266961 had a related patch set uploaded (by Alex Monk):
Run VE->WTE modification checks regardless of how the user got into VE

https://gerrit.wikimedia.org/r/266961

gerritbot added a project: Patch-For-Review.Jan 28 2016, 2:32 AM
tarlocesilion subscribed.Jan 29 2016, 2:46 AM
Jdforrester-WMF edited a custom field.Jan 30 2016, 12:08 AM
Jdforrester-WMF updated the task description. (Show Details)Jan 30 2016, 3:35 AM
gerritbot added a comment.Jan 30 2016, 3:48 AM

Change 266961 merged by jenkins-bot:
Run VE->WTE modification checks regardless of how the user got into VE

https://gerrit.wikimedia.org/r/266961

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 30 2016, 4:00 AM
Krenair closed this task as Resolved.Feb 4 2016, 1:31 AM

Forgot to close this earlier... That should have fixed things. It's part of wmf.12 which is already deployed on group0/group1 wikis and is expected to be going to wikipedias later today.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits