Page MenuHomePhabricator

[Task] Remove all unused value() methods from view widgets
Closed, ResolvedPublic

Description

The value methods are usually very expensive, because they create new Wikibase-DataModel-JavaScript objects from what's currently in the edit window(s) on screen. This is usually done for two purposes:

  1. isInitialValue checks if the user changed something and the save button should be enabled. This is T124786: [Task] Widgets should delegate isInitialValue calls as far as possible.
  2. stopEditing stores the changed value.

Neither of this requires the value method, when done properly. When all such usages of a value method are removed, the method should be removed.

Event Timeline

Change 287611 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace expensive statementview.isValid implementation

https://gerrit.wikimedia.org/r/287611

Change 287611 merged by jenkins-bot:
Replace expensive statementview.isValid implementation

https://gerrit.wikimedia.org/r/287611