Page MenuHomePhabricator
Create Task
Maniphest T124798

Normalize PageAssessments DB schema
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Now that we are doing all the DB interactions via the Job Queue, there's really no reason to super-optimize the queries. We should remove the denormalization of the page information in the schema and just use the page_id. This may also require modifying some of the queries.

Details

SubjectRepoBranchLines +/-
Normalize database for PageAssessmentsmediawiki/extensions/PageAssessmentsmaster+21 -33
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT120219 PageAssessments deployment to WMF wikis
 Resolved• NiharikaT124798 Normalize PageAssessments DB schema

Event Timeline

kaldari created this task.Jan 26 2016, 6:17 PM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Community-Tech.
kaldari subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 26 2016, 6:17 PM
Johan subscribed.Jan 26 2016, 6:17 PM
kaldari triaged this task as Medium priority.Jan 26 2016, 6:17 PM
kaldari moved this task from New & TBD Tickets to Up Next on the Community-Tech board.
kaldari set Security to None.
kaldari updated the task description. (Show Details)
kaldari added a subscriber: • Niharika.
• DannyH added a parent task: T120219: PageAssessments deployment to WMF wikis.Jan 26 2016, 6:18 PM
kaldari added subscribers: jcrespo, aaron.Jan 26 2016, 6:20 PM

Would also be good to have @jcrespo and @aaron review the schema.

kaldari updated the task description. (Show Details)Jan 26 2016, 6:21 PM
kaldari added a comment.Jan 26 2016, 8:59 PM

Aaron says that joining with the page table isn't very expensive and it will probably be better to just use the page_id.

He also proposed a couple of other schema changes:
https://gerrit.wikimedia.org/r/#/c/266584/
https://gerrit.wikimedia.org/r/#/c/266583/

aaron added a comment.Jan 26 2016, 9:37 PM
In T124798#1967268, @kaldari wrote:

Aaron says that joining with the page table isn't very expensive and it will probably be better to just use the page_id.

He also proposed a couple of other schema changes:
https://gerrit.wikimedia.org/r/#/c/266584/
https://gerrit.wikimedia.org/r/#/c/266583/

Just make sure you are not trying to sort on namespace/title or something :)

kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.Jan 27 2016, 8:41 PM
• Niharika edited a custom field.EditedJan 28 2016, 3:09 PM
• Niharika added a subscriber: • Fhocutt.

@Fhocutt, this task might affect some of the API queries too. Just a heads up.

• Niharika claimed this task.Jan 28 2016, 3:27 PM
• Niharika moved this task from Ready to In Development on the Community-Tech-Sprint board.
gerritbot subscribed.Feb 1 2016, 7:20 AM

Change 267638 had a related patch set uploaded (by Niharika29):
Normalize database for PageAssessments

https://gerrit.wikimedia.org/r/267638

gerritbot added a project: Patch-For-Review.Feb 1 2016, 7:20 AM
• Niharika moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Feb 1 2016, 10:11 AM
gerritbot added a comment.Feb 2 2016, 10:28 PM

Change 267638 merged by jenkins-bot:
Normalize database for PageAssessments

https://gerrit.wikimedia.org/r/267638

kaldari closed this task as Resolved.Feb 2 2016, 10:57 PM
kaldari moved this task from Needs Review/Feedback to Q3 2018-19 on the Community-Tech-Sprint board.
• MZMcBride subscribed.Feb 3 2016, 5:10 AM
• DannyH moved this task from Q3 2018-19 to Q1 2018-19 on the Community-Tech-Sprint board.Feb 4 2016, 1:34 AM
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Feb 17 2016, 1:39 AM
• DannyH moved this task from Up Next to Archive on the Community-Tech board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL