Page MenuHomePhabricator

Normalize PageAssessments DB schema
Closed, ResolvedPublic2 Estimated Story Points

Description

Now that we are doing all the DB interactions via the Job Queue, there's really no reason to super-optimize the queries. We should remove the denormalization of the page information in the schema and just use the page_id. This may also require modifying some of the queries.

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNiharika

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Community-Tech.
kaldari subscribed.
kaldari triaged this task as Medium priority.Jan 26 2016, 6:17 PM
kaldari moved this task from New & TBD Tickets to Up Next on the Community-Tech board.
kaldari set Security to None.
kaldari updated the task description. (Show Details)
kaldari added a subscriber: Niharika.

Would also be good to have @jcrespo and @aaron review the schema.

Aaron says that joining with the page table isn't very expensive and it will probably be better to just use the page_id.

He also proposed a couple of other schema changes:
https://gerrit.wikimedia.org/r/#/c/266584/
https://gerrit.wikimedia.org/r/#/c/266583/

Aaron says that joining with the page table isn't very expensive and it will probably be better to just use the page_id.

He also proposed a couple of other schema changes:
https://gerrit.wikimedia.org/r/#/c/266584/
https://gerrit.wikimedia.org/r/#/c/266583/

Just make sure you are not trying to sort on namespace/title or something :)

Niharika added a subscriber: Fhocutt.

@Fhocutt, this task might affect some of the API queries too. Just a heads up.

Change 267638 had a related patch set uploaded (by Niharika29):
Normalize database for PageAssessments

https://gerrit.wikimedia.org/r/267638

Change 267638 merged by jenkins-bot:
Normalize database for PageAssessments

https://gerrit.wikimedia.org/r/267638