Page MenuHomePhabricator

Creating a new topic with a mention generates both events
Closed, ResolvedPublic

Description

If someone mentions you in a new topic on a board you watch, you can both the new-topic and flow-mention notifications. In the other similar cases (reply+mention, post-edited+mention, topic-renamed+mention) you don't get the flow-mention notification.

Event Timeline

SBisson created this task.Jan 26 2016, 6:27 PM
SBisson updated the task description. (Show Details)
SBisson raised the priority of this task from to Needs Triage.
SBisson added a subscriber: SBisson.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 26 2016, 6:27 PM

Change 269405 had a related patch set uploaded (by Matthias Mullie):
Don't trigger new-topic notification when user is also mentioned in first post

https://gerrit.wikimedia.org/r/269405

matthiasmullie set Security to None.

Change 269405 merged by jenkins-bot:
Don't trigger new-topic notification when user is also mentioned in first post

https://gerrit.wikimedia.org/r/269405

Checked in betalabs - no duplicate notificaitons for

  • when Mention is in the title of a new topic
  • when Mention is in the body of a new topic
  • when several topics were created simultaneously with Mention not in all of them

e.g. three topics were created, and Mention was in only one of the topics. The notifications will come as '2 new topics on a flow board' and 'a user mention you in [third new topic]

However, user talk pages still send duplicate notifications - it might be viewed as a feature?

Change 269958 had a related patch set uploaded (by Matthias Mullie):
Comparing User objects is inreliable

https://gerrit.wikimedia.org/r/269958

@Etonkovidova: it wasn't meant as feature :)
https://gerrit.wikimedia.org/r/#/c/269958/ should fix that on user talk pages too.

[...]
However, user talk pages still send duplicate notifications - it might be viewed as a feature?

What are the exact steps you are doing? I can't reproduce it.

User names refer to the screenshots below:

  1. As a user ET70, create a new topic on User talk:ET1: mention ET1 in the body of the topic.

  1. User ET1 receives two notificaitons - one about a new topic and about mentioning with the same timestamp.

User names refer to the screenshots below:

  1. As a user ET70, create a new topic on User talk:ET1: mention ET1 in the body of the topic.

  2. User ET1 receives two notificaitons - one about a new topic and about mentioning with the same timestamp.

Got it. I thought you meant wikitext talk page... I was confused.

Change 269958 merged by jenkins-bot:
Comparing User objects is unreliable

https://gerrit.wikimedia.org/r/269958

Verified the fix in betalabs - User talk page sends only 'Mention' notification if Mention occurs in a new topic.

jmatazzoni closed this task as Resolved.Feb 19 2016, 6:50 PM
jmatazzoni added a subscriber: matthiasmullie.