Page MenuHomePhabricator
Create Task
Maniphest T124806

MobileFrontend uses unsupported jQuery Sizzle selector
Closed, ResolvedPublic
Actions

Description

When trying to upgrade MediaWiki from jQuery 1.11.3 to jQuery 1.12.0 (supposed to be a minor release) one unit test fails in MobileFrontend.

Observed at https://gerrit.wikimedia.org/r/266093 and https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/27568.

Chromium 47.0.2526 (Ubuntu 0.0.0) MobileFrontend toggle.js: Mobile mode. Clicking hash links FAILED

Error: Syntax error, unrecognized expression: [href=#First_Section]
 at Sizzle.tokenize
 at jQuery.fn.extend.find

See also http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/. This previously worked by accident due to jQuery's selector parser being more tolerant than the standard/native implementation. The older version often needlessly used the fallback. The new one does not.

document.querySelectorAll('[href=#Foo]')
// Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '[href=#Foo]' is not a valid selector.(…)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use correct selector syntax in QUnit testmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Jan 26 2016, 6:49 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MobileFrontend, JavaScript.
Krinkle subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 26 2016, 6:49 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 26 2016, 11:48 PM
Jdforrester-WMF added a project: Technical-Debt.
Jdforrester-WMF set Security to None.
Krinkle added a parent task: T124742: Upgrade to jQuery 3.Jan 27 2016, 12:10 AM
Ricordisamoa subscribed.Jan 27 2016, 12:37 AM
Florian claimed this task.Jan 27 2016, 6:13 AM
gerritbot subscribed.Jan 27 2016, 6:15 AM

Change 266667 had a related patch set uploaded (by Florianschmidtwelzow):
Use correct selector syntax in QUnit test

https://gerrit.wikimedia.org/r/266667

gerritbot added a project: Patch-For-Review.Jan 27 2016, 6:15 AM
Krinkle closed this task as Resolved.Jan 27 2016, 11:06 AM
gerritbot added a comment.Jan 27 2016, 11:11 AM

Change 266667 merged by jenkins-bot:
Use correct selector syntax in QUnit test

https://gerrit.wikimedia.org/r/266667

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 27 2016, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits