Page MenuHomePhabricator

Add "About this article" to ToC
Closed, ResolvedPublic2 Estimated Story Points


All articles with "About this article" footer sections should also have a ToC item for "About this article"

Event Timeline

JMinor raised the priority of this task from to Medium.
JMinor updated the task description. (Show Details)
JMinor added a subscriber: JMinor.

I would like to claim this task. Could anyone help to provide a sample article containing a "About this article" footer section? So I can get started.

JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.1.0-Saturn board.
JoeWalsh added a subscriber: JoeWalsh.
Fjalapeno set the point value for this task to 2.Jun 16 2016, 5:11 PM

To test:

  1. Open any article
  2. Open the Table of Contents
  3. Scroll to the bottom of the table of contents
  4. Verify that you see an "About this Article" section
  5. Tap on the "About this Article" section
  6. Verify the article scrolled to "about this article" section

Testing on Wikipedia app 5.0.5 (884) on iOS 9.3.2 iPhone. This is fixed as the article I tested with scrolled to "About this Article" section after tapping it in the Table of Contents.

Fjalapeno added a subscriber: RHo.

@RHo this was already QA'd - just move directly to PM sign off after you review

hey @Fjalapeno - there is just a minor visual design bug where a second separator line is appearing underneath the "About this article" item in the TOC.

iPhone 6S Plus
File_000.png (2×1 px, 448 KB)
iPhone 4S (Similator)
Simulator Screen Shot Jun 24, 2016, 12.46.40 PM.png (960×640 px, 90 KB)

I originally put this comment on the wrong task. Moving it here.

@RHo should Read More have a line below it? Easiest fix looks like this:

Simulator Screen Shot Jun 24, 2016, 7.00.06 AM.png (1×750 px, 146 KB)

But I can add the line below the last item if necessary.

Ah @JoeWalsh I just commented on the other ticket, but yes - please also remove the line below Read more. Thanks!

(I'll delete comments from the other ticket.)

Just simulated on iPhone 4S, 6S, iPad 2 and iPad Air 2 and LGTM.