Page MenuHomePhabricator
Create Task
Maniphest T124847

Add "About this article" to ToC
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
JoeWalsh
Authored By
• JMinor
Jan 27 2016, 12:17 AM
Tags
Referenced Files
F4197677: Simulator Screen Shot Jun 24, 2016, 7.00.06 AM.png
Jun 24 2016, 11:04 AM
F4197623: Simulator Screen Shot Jun 24, 2016, 12.46.40 PM.png
Jun 24 2016, 10:48 AM
F4197520: File_000.png
Jun 24 2016, 10:29 AM
Subscribers
Aklapper
• Fjalapeno
huayu0723
• JMinor
JoeWalsh
Nicholas.tsg
RHo

Description

All articles with "About this article" footer sections should also have a ToC item for "About this article"

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• JMinorT126635 EPIC: Improve Table of Content UX
 ResolvedJoeWalshT124847 Add "About this article" to ToC

Event Timeline

• JMinor created this task.Jan 27 2016, 12:17 AM
• JMinor raised the priority of this task from to Medium.
• JMinor updated the task description. (Show Details)
• JMinor added projects: iOS-app-v5-production, Wikipedia-iOS-App-Development.
• JMinor added a subscriber: • JMinor.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2016, 12:17 AM
• JMinor moved this task from Tasks from Product Backlog to Needs Estimation on the Wikipedia-iOS-App-Development board.Jan 27 2016, 12:17 AM
• JMinor added a parent task: T126635: EPIC: Improve Table of Content UX.Feb 11 2016, 6:32 PM
• JMinor removed a parent task: T126635: EPIC: Improve Table of Content UX.
• JMinor added a parent task: T126635: EPIC: Improve Table of Content UX.
MBinder_WMF moved this task from Needs Estimation to Needs Acceptance Criteria on the Wikipedia-iOS-App-Development board.Feb 11 2016, 9:46 PM
• JMinor moved this task from Needs Acceptance Criteria to Needs Estimation on the Wikipedia-iOS-App-Development board.Feb 23 2016, 11:07 PM
• JMinor edited projects, added iOS-app-v5.0.1-Kiwi; removed iOS-app-v5-production.Mar 1 2016, 1:27 AM
MBinder_WMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Development.Mar 1 2016, 10:21 PM
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Mar 7 2016, 8:35 PM
• JMinor edited projects, added iOS-app-v5.1.0-Saturn; removed iOS-app-v5.0.1-Kiwi.Mar 10 2016, 10:48 PM
• JMinor moved this task from Backlog to Needs Estimation on the iOS-app-v5.1.0-Saturn board.May 9 2016, 9:25 PM
• JMinor moved this task from Needs Estimation to Ready for Development on the iOS-app-v5.1.0-Saturn board.Jun 9 2016, 5:35 PM
huayu0723 added a subscriber: huayu0723.Jun 15 2016, 8:18 AM

I would like to claim this task. Could anyone help to provide a sample article containing a "About this article" footer section? So I can get started.

JoeWalsh claimed this task.Jun 15 2016, 1:47 PM
JoeWalsh moved this task from Ready for Development to Doing on the iOS-app-v5.1.0-Saturn board.
JoeWalsh added a comment.Jun 15 2016, 2:29 PM

https://github.com/wikimedia/wikipedia-ios/pull/718

JoeWalsh removed JoeWalsh as the assignee of this task.Jun 15 2016, 2:30 PM
JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.1.0-Saturn board.
JoeWalsh added a subscriber: JoeWalsh.
• Fjalapeno assigned this task to JoeWalsh.Jun 15 2016, 8:07 PM
• Fjalapeno set the point value for this task to 2.Jun 16 2016, 5:11 PM
JoeWalsh mentioned this in rAPIOS438887660bf0: Merge branch 'develop' into about_this_article/T124847.Jun 20 2016, 6:48 PM
Diffusion mentioned this in rAPIOSf3a22ab25ed9: Merge pull request #718 from wikimedia/about_this_article/T124847.Jun 20 2016, 7:48 PM
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jun 20 2016, 9:15 PM
• Fjalapeno added a subscriber: • Fjalapeno.Jun 21 2016, 2:21 PM

To test:

  1. Open any article
  2. Open the Table of Contents
  3. Scroll to the bottom of the table of contents
  4. Verify that you see an "About this Article" section
  5. Tap on the "About this Article" section
  6. Verify the article scrolled to "about this article" section
• Fjalapeno moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.1.0-Saturn board.Jun 21 2016, 2:21 PM
• Fjalapeno moved this task from Needs Design Review to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jun 21 2016, 6:10 PM
• Fjalapeno moved this task from Ready for PM Signoff to Needs QA on the iOS-app-v5.1.0-Saturn board.
Nicholas.tsg added a subscriber: Nicholas.tsg.Jun 22 2016, 11:35 PM

Testing on Wikipedia app 5.0.5 (884) on iOS 9.3.2 iPhone. This is fixed as the article I tested with scrolled to "About this Article" section after tapping it in the Table of Contents.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jun 22 2016, 11:36 PM
• Fjalapeno moved this task from Ready for PM Signoff to Needs Design Review on the iOS-app-v5.1.0-Saturn board.Jun 23 2016, 4:52 PM
• Fjalapeno added a subscriber: RHo.

@RHo this was already QA'd - just move directly to PM sign off after you review

RHo moved this task from Needs Design Review to Blocked or Waiting on the iOS-app-v5.1.0-Saturn board.EditedJun 24 2016, 10:29 AM

hey @Fjalapeno - there is just a minor visual design bug where a second separator line is appearing underneath the "About this article" item in the TOC.

iPhone 6S Plus
File_000.png (2×1 px, 448 KB)
iPhone 4S (Similator)
Simulator Screen Shot Jun 24, 2016, 12.46.40 PM.png (960×640 px, 90 KB)
JoeWalsh added a comment.Jun 24 2016, 11:04 AM

I originally put this comment on the wrong task. Moving it here.

@RHo should Read More have a line below it? Easiest fix looks like this:

Simulator Screen Shot Jun 24, 2016, 7.00.06 AM.png (1×750 px, 146 KB)

But I can add the line below the last item if necessary.

RHo added a comment.Jun 24 2016, 11:07 AM

Ah @JoeWalsh I just commented on the other ticket, but yes - please also remove the line below Read more. Thanks!

(I'll delete comments from the other ticket.)

JoeWalsh added a comment.Jun 24 2016, 11:09 AM

Ok - fix is ready for code review: https://github.com/wikimedia/wikipedia-ios/pull/738

JoeWalsh moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v5.1.0-Saturn board.Jun 24 2016, 11:09 AM
• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jun 24 2016, 2:24 PM
• Fjalapeno moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.
• Fjalapeno moved this task from Ready for PM Signoff to Needs Design Review on the iOS-app-v5.1.0-Saturn board.
RHo added a comment.Jun 24 2016, 2:44 PM

Just simulated on iPhone 4S, 6S, iPad 2 and iPad Air 2 and LGTM.

RHo moved this task from Needs Design Review to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jun 24 2016, 2:45 PM
• JMinor edited projects, added iOS-app-v5.0.5-Fever; removed iOS-app-v5.1.0-Saturn.Jun 30 2016, 6:33 PM
• JMinor moved this task from Tasks from Product Backlog to Ready for PM Signoff on the iOS-app-v5.0.5-Fever board.Jun 30 2016, 6:39 PM
• JMinor closed this task as Resolved.Jul 6 2016, 9:47 PM
MBinder_WMF added a project: iOS-app-feature-TOC.Jul 9 2016, 12:15 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL