Page MenuHomePhabricator

MultiUpload's unpack function should be more Windows-friendly
Open, MediumPublic

Description

Filing this for future reference, right now MultiUpload's so broken under MW 1.26+ that it's not even funny...

MultiUploadApiUnpack::unpack (in MultiUploadApi.php) hard-codes certain shell commands, namely the usage of tar or unzip to untar/unzip a .tar/.tar.gz/.zip file. This works well on most *NIX-like systems where said binaries are available, but not so much on Windows. Windows users should have a way to configure MultiUpload to use 7-Zip instead.

Related StackOverflow thread about unzipping files via CLI on Windows

Event Timeline

ashley created this task.Jan 27 2016, 3:32 PM
ashley claimed this task.
ashley raised the priority of this task from to Medium.
ashley updated the task description. (Show Details)
ashley added a subscriber: ashley.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2016, 3:32 PM

@ashley Can this be closed since you made a commit at https://gerrit.wikimedia.org/r/#/c/334788/ ? It mentions "Windows unzipping support in the API module", but it also says "sorta" at the end of that comment

@ashley Can this be closed since you made a commit at https://gerrit.wikimedia.org/r/#/c/334788/ ? It mentions "Windows unzipping support in the API module", but it also says "sorta" at the end of that comment

No. The linked patch adds unzip support for MultiUpload under Windows, but that's it. Just unzip, no untar or anything for handling .tar(.gz) files, or rather, for configuring 7-Zip or somesuch to handle those, and that's what this ticket is about.

Aklapper removed ashley as the assignee of this task.Jun 19 2020, 4:23 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)