Page MenuHomePhabricator

Look into not serving OOUI styles for IE 6 and 7
Closed, DeclinedPublic

Description

We should look into not serving OOUI styles for IE 6 and 7. That might be a better way of providing grade C support (T124905) than trying to make the style look right.

OOUI PHP is mostly using fairly semantic HTML for the widgets, and the demo page looks almost good when stripped of its styles:

We could probably make it pretty good by switching some <div>s to <span>s and maybe adding some <p>s in strategic locations. That would surely be a good thing to do anyway.

Event Timeline

matmarex created this task.Jan 27 2016, 5:47 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex added a subscriber: matmarex.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 27 2016, 5:47 PM

We'd probably need ResourceLoader support for IE conditional comments, or bypass it for loading the styles.

For a more practical example, here's how Special:BlockList currently looks on IE 6:

And here's how it would look without any OOjs UI PHP styles:

After weighing in at a longer conversation with @matmarex the necessary work needed to make several widgets acceptable rendered in IE 6&7, also with regard of future maintenance and extensibility, not serving the styles to these two browsers and let it just render native browser widgets seems to be the best solution.

I'm inclined to agree as well. Looking at the second image in T124932#1970430, we might also want to use <fieldset> for OouiHtmlForm.

Implementation isn't trivial though, because we have quite a few abstraction layers interacting at the edges. If we want to exclude with conditional comments, that is. Not sure that's worth it.

Might be better to improve the semantic nature of the HTML. Then, even with the broken CSS applied, it will render more gracefully from a better starting point.

If we really want to unload some CSS, I'd recommend we reconsider and instead evaluate possibility of a "Universal stylesheet" for IE6-7 (with all regular styles unloaded, not just OOUI, in favour of a super generic base stylesheet - skin agonistic).

Krinkle triaged this task as Medium priority.Jan 28 2016, 10:49 PM
Krinkle set Security to None.
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.

I'm inclined to agree as well. Looking at the second image in T124932#1970430, we might also want to use <fieldset> for OouiHtmlForm.

As discussed on https://gerrit.wikimedia.org/r/#/c/273761/, fieldset & legend are particularly difficult to style accurately - so this may be to the detriment of grade A browsers.

Volker_E renamed this task from Look into not serving OOjs UI styles for IE 6 and 7 to Look into not serving OOUI styles for IE 6 and 7.Jan 6 2018, 7:44 AM
Volker_E updated the task description. (Show Details)
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 6 2018, 7:44 AM