Page MenuHomePhabricator

Add classes to elements on the navbar
Closed, DeclinedPublic

Description

While you're at it, could you add some classes, too?
Selections like $('.navbar-collapse > .navbar-nav')[1] are very error prone as they depend on the order of the HTML elements. If it had a class / id, it would me much easier to select (and customize)

Event Timeline

Foxtrott created this task.Jan 27 2016, 8:25 PM
Foxtrott claimed this task.
Foxtrott raised the priority of this task from to Medium.
Foxtrott updated the task description. (Show Details)
Foxtrott added subscribers: Foxtrott, Fannon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2016, 8:25 PM
Foxtrott set Security to None.

Elements on the NavBar have an ID, e.g. n-mainpage-description or ca-talk.
These should additionally be available as classes, but otherwise... whatś missing?

Foxtrott moved this task from Backlog to Enhancements on the Chameleon board.Feb 8 2016, 9:25 PM
Foxtrott lowered the priority of this task from Medium to Low.Feb 8 2016, 9:34 PM
Foxtrott added a project: good first task.
Danny_B moved this task from Backlog to Doing on the good first task board.Feb 18 2016, 3:33 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 9 2016, 9:43 PM