As a user, when I search for something for no results, then I shouldn't see a banner so that the error is less overwhelming
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• BGerstle-WMF
	Jan 27 2016, 9:48 PM

Description

We're already displaying an error view where results go, just suppress the banner for that particular "error":

Spec

Search View

Scenario: Entering & running searches

When I search for something that has 0 results
Then I should eventually see an error view where search results normally go
And it should say there are no results
And I should not see an error banner

Related Objects

Mentioned In: rAPIOS840115c143dc: Merge pull request #432 from wikimedia/feature/T124982/search-no-results-banner
Mentioned Here: T126087: change 0 results copy

Event Timeline

• BGerstle-WMF created this task.Jan 27 2016, 9:48 PM

• BGerstle-WMF raised the priority of this task from to Needs Triage.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF added a project: Wikipedia-iOS-App-Development.

• BGerstle-WMF moved this task to Ready for Development on the Wikipedia-iOS-App-Development board.

• BGerstle-WMF subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 27 2016, 9:48 PM

• BGerstle-WMF triaged this task as Low priority.Jan 27 2016, 9:49 PM

• BGerstle-WMF added projects: iOS-app-v5-production, Essential-Work.

• BGerstle-WMF set Security to None.

• Fjalapeno claimed this task.Jan 29 2016, 5:26 PM

• Fjalapeno moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Development board.

• Fjalapeno moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.

• BGerstle-WMF mentioned this in rAPIOS840115c143dc: Merge pull request #432 from wikimedia/feature/T124982/search-no-results-banner.Jan 29 2016, 7:02 PM

• BGerstle-WMF moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Feb 1 2016, 3:54 PM

Checked with 5.0.0 (672) on iPad mini iOS 8.2 and iPhone 6 iOS 9.0.
Without that black banner it looks much better now

vs 5.0.0.565

Note: "Could not load any results" subtly implies some technical difficulties, not simply a fact that 'No matches for search item" or, as Android app displays:

Screenshot_2016-02-05-14-53-00.png (1×1 px, 106 KB)

Etonkovidova moved this task from Needs QA to Needs Design Review on the Wikipedia-iOS-App-Development board.Feb 5 2016, 11:00 PM

New ticket to change 0 result message to match Android: T126087

This particular issue with the obtrusive banner is fixed. And thank you Jebus, because it was annoying.

• JMinor moved this task from Needs Design Review to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Feb 5 2016, 11:17 PM

	F3314617: Screenshot_2016-02-05-14-53-00.png
	Feb 5 2016, 10:58 PM

As a user, when I search for something for no results, then I shouldn't see a banner so that the error is less overwhelmingClosed, ResolvedPublicActions