Page MenuHomePhabricator

Merge into Master and deploy to Beta Portal
Closed, ResolvedPublic

Description

Hi there - we have several fixes and code updates to be merged into Master and then deployed into the Portal Beta site so we can test.

Here's the tickets:
https://phabricator.wikimedia.org/T120422 (fix for scroll bar)
https://phabricator.wikimedia.org/T119486 (fix for FOUC)
https://phabricator.wikimedia.org/T124713 (removing inline JS)
https://phabricator.wikimedia.org/T124091 (create integration tests)

Event Timeline

debt raised the priority of this task from to High.
debt updated the task description. (Show Details)
debt added subscribers: debt, Jdrewniak, JGirault, MaxSem.
debt renamed this task from Push to Beta Portal - scroll bar fix to Merge into Master and deploy to Beta Portal.Jan 28 2016, 7:40 PM
debt updated the task description. (Show Details)
debt set Security to None.

master is deployed to http://www.wikipedia.beta.wmflabs.org/

Thanks to @MaxSem for showing me how to do this.

Note: the fix for scrollbar T120422 is not testable because... we removed the A/B/C test so we're back to the old search box for all users.

Thanks, @JGirault, @MaxSem and @Jdrewniak!

How can we make sure that the scroll bar bug doesn't raise it's ugly head again with subsequent A/B/C testing?

Thanks, @JGirault, @MaxSem and @Jdrewniak!

How can we make sure that the scroll bar bug doesn't raise it's ugly head again with subsequent A/B/C testing?

Maybe we could add some kind of automated test to alert us if that regression appears again? I don't know how easy that is, but it's worth considering.

Added in portal integration tests as a blocker to this...so that we don't have any regression.

Marking as done - @JGirault has got this process figured out.