Hi there - we have several fixes and code updates to be merged into Master and then deployed into the Portal Beta site so we can test.
Here's the tickets:
https://phabricator.wikimedia.org/T120422 (fix for scroll bar)
https://phabricator.wikimedia.org/T119486 (fix for FOUC)
https://phabricator.wikimedia.org/T124713 (removing inline JS)
https://phabricator.wikimedia.org/T124091 (create integration tests)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T124993 EPIC: Next deployment of portal page to production (bug fixes, remove inline JS) | |||
| Resolved | • JGirault | T125100 Merge into Master and deploy to Beta Portal | |||
| Resolved | Jdrewniak | T120422 The new language selection dropdown in the first A/B test on Wikipedia portal is missing scroll bar in chrome, but works in FF | |||
| Resolved | Jdrewniak | T119486 Brief FOUC before the search icon is rendered | |||
| Resolved | • JGirault | T124713 Stop inlining Portal JavaScript (create a file to be requested) | |||
| Resolved | Jdrewniak | T124091 Create integration tests for portal (to prevent regressions with A/B testing) |
master is deployed to http://www.wikipedia.beta.wmflabs.org/
Thanks to @MaxSem for showing me how to do this.
Note: the fix for scrollbar T120422 is not testable because... we removed the A/B/C test so we're back to the old search box for all users.
Thanks, @JGirault, @MaxSem and @Jdrewniak!
How can we make sure that the scroll bar bug doesn't raise it's ugly head again with subsequent A/B/C testing?
Maybe we could add some kind of automated test to alert us if that regression appears again? I don't know how easy that is, but it's worth considering.
Added in portal integration tests as a blocker to this...so that we don't have any regression.