Page MenuHomePhabricator

Re-evaluate Flow user locators (who gets notified) for notifications
Closed, ResolvedPublic

Description

Some of these seem overly strict, and people might miss notifications they'd want.

E.g. topic renames are pretty rare, so it seems worth notifying everyone who is watching the topic (currently it is just original topic creator, and the talk page owner if it's user talk). There are probably other cases.

See user-locators fields under https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/master/includes%2FNotifications%2FNotifications.php#L11 . That references EchoUserLocator and Flow\NotificationsUserLocator.

Event Timeline

Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 28 2016, 6:30 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

@Mattfkaschen, when you say:

Some of these seem overly strict

You are, I assume, speaking about the "Flow user locators"? Where would I see those rules?

Mattflaschen-WMF set Security to None.

@Mattfkaschen, when you say:

Some of these seem overly strict

You are, I assume, speaking about the "Flow user locators"? Where would I see those rules?

I don't know if they're documented anywhere. The code is somewhat understandable, but someone should actually document it on-wiki, if it's not already.

This is the list of who currently gets which notification:

flow-new-topic:

  • users watching the board
  • owner of the user talk page

flow-post-reply:

  • users watching the topic
  • owner of the user talk page

flow-post-edited:

  • post author
  • owner of the user talk page

flow-topic-renamed:

  • topic author
  • owner of the user talk page

flow-mention:

  • users that were mentioned (except if they got another notification for this same event)

flow-enabled-on-talkpage:

  • owner of the user talk page

flow-mention notifications are only sent when a new post/topic are submitted. We should probably also expact that to post, topic & header edits (if a new user is mentioned after the edit)?

matthiasmullie closed this task as Resolved.Feb 4 2016, 12:36 PM
matthiasmullie claimed this task.

Closing this. Stephane already created a bunch of new tickets that came out of this re-evaluation.