Page MenuHomePhabricator

Fatal Call to a member function getTitle() on a non-object (NULL) following wmf11 to all wikis
Closed, ResolvedPublic

Description

https://logstash.wikimedia.org/#dashboard/temp/AVKKJ879ptxhN1XaK1EZ

From fatalmonitor:

 	Warning: Destructor threw an object exception: exception 'BadMethodCallException' with message 'Call to a member function getTitle() on a non-object (NULL)' in /srv/mediawiki/php-1.27.0-wmf.11/extensions/WikimediaEvents/WikimediaEventsHooks.php:190
Stack trace:
#0 /srv/mediawiki/php-1.27.0-wmf.11/includes/Hooks.php(195): WikimediaEventsHooks::onUserSaveOptions()
#1 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(5105): Hooks::run()
#2 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(3681): User->saveOptions()
#3 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionBackend.php(553): User->saveSettings()
#4 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionBackend.php(517): MediaWiki\Session\SessionBackend->save()
#5 /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/ScopedCallback.php(74): Closure$MediaWiki\Session\SessionBackend::delaySave()
#6 /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/ScopedCallback.php(54): ScopedCallback->__destruct()
#7 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(920): ScopedCallback::consume()
#8 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(187): MediaWiki\Session\SessionManager->getSessionFromInfo()
#9 /srv/mediawiki/php-1.27.0-wmf.11/includes/WebRequest.php(664): MediaWiki\Session\SessionManager->getSessionForRequest()
#10 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(121): WebRequest->getSession()
#11 /srv/mediawiki/php-1.27.0-wmf.11/includes/Setup.php(712): MediaWiki\Session\SessionManager::getGlobalSession()
#12 /srv/mediawiki/php-1.27.0-wmf.11/includes/WebStart.php(156): include()
#13 /srv/mediawiki/php-1.27.0-wmf.11/index.php(40): include()
#14 /srv/mediawiki/w/index.php(3): include()
#15 {main} in /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/ScopedCallback.php on line 54

Event Timeline

dduvall created this task.Jan 28 2016, 9:32 PM
dduvall raised the priority of this task from to High.
dduvall updated the task description. (Show Details)
dduvall added subscribers: dduvall, bd808, Anomie and 3 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2016, 9:32 PM
greg updated the task description. (Show Details)Jan 28 2016, 9:32 PM
greg set Security to None.

Change 267146 had a related patch set uploaded (by Gergő Tisza):
Guard against $wgOut not existing

https://gerrit.wikimedia.org/r/267146

greg updated the task description. (Show Details)Jan 28 2016, 9:34 PM
Tgr added a comment.Jan 28 2016, 9:35 PM

Probably happens when the user's token is updated and that causes a settings save, when the session is initialized in Setup.php (right before $wgOut is set)?

Change 267153 had a related patch set uploaded (by Dduvall):
Guard against $wgOut not existing

https://gerrit.wikimedia.org/r/267153

Change 267146 merged by jenkins-bot:
Guard against $wgOut not existing

https://gerrit.wikimedia.org/r/267146

Change 267153 merged by jenkins-bot:
Guard against $wgOut not existing

https://gerrit.wikimedia.org/r/267153

Tgr closed this task as Resolved.Jan 30 2016, 10:00 AM
Tgr claimed this task.