Page MenuHomePhabricator

Saved pages can't be refreshed anymore (under some circumstances)
Closed, InvalidPublic1 Estimated Story Points

Description

Description

With the last update, it seems the saved pages function is a bit broken in a special case. The original request comes from a german user in OTRS.

While reproducing this problem I observed two things:
The first: If you navigate through the app (clicking on some links and go from page to page) and save all pages you open, the app at some point simply crashes, without any error message or a way to report it. I could reproduce this any time, but it seems it's a bit random when (I couldn't find out a schema about how many pages you need to save or how big they need to be, so the easiest would be: click any link without reading the article and save all pages you visit, until the app crashes).

The second one:
If you save some pages (the user in OTRS had 15, I needed to save some more, around 20) and after it go to the saved pages, click the refresh button, you simply get the "Refreshing" dialog, but it will not disapear and the app does nothing until you use the back key and/or close the app.

Steps to reproduce

  1. Open several pages and save them (maybe you need some bigger ones, maybe 20-30 pages)
  2. Open the saved pages menü
  3. Tap on the refresh circle at the top right
  4. Tap on "yes" to start the updating process
  5. Wait some minutes

Expected results

The pages should be refreshed and the dialog should disapear.

Actual results

The dialog keeps indicating, that the pages are refreshed, but it seems, that the app does nothing. The WiFi/mobile data icon in the status bar doesn't show any data traffic, too.

Screenshot_20160129-215409.png (1×1 px, 152 KB)

Environments observed

App version: 2.1.138-r-2016-01-21
Android OS versions: Android 6.0
Device model: HTC One M9
Device language: german (de)

Event Timeline

Florian raised the priority of this task from to Unbreak Now!.
Florian updated the task description. (Show Details)
Florian subscribed.

I'm not sure, but this could be realated: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8953122

If not, we would need to open a new task for it :)

Hi!
I'm the mentioned german user :D
Relating to the second problem:
I guess, that it's depending on how much memory is used by the saved pages, because it doesn't matter how many of them are saved (10 huge pages with many pics or 30 tiny ones).
Howsoever ... the problems started, when ca. 3,5-3,7 MB memory is used for the saved pages on my devices.

Dbrant lowered the priority of this task from Unbreak Now! to Medium.Feb 3 2016, 8:11 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.

Lowering priority (not because it's not an important task!) It's still near the top of the backlog, and we'll revisit it very soon.

MBinder_WMF set the point value for this task to 1.May 18 2016, 7:23 PM

With the introduction of reading lists, the app saves pages in a fundamentally different way.