Page MenuHomePhabricator
Create Task
Maniphest T125288

Patrol links show up even though patrolling is disabled on the wiki
Closed, ResolvedPublic
Actions

Description

I was browsing around officewiki and noticed a [Mark this page as patrolled] link. I clicked on it, and got a failure message. The API response was: "info": "Patrolling is disabled on this wiki".

So if that's the case...we shouldn't be showing the patrol links in the first place.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't show patrol links if RCP/NPP are disabled, but file patrol isn'tmediawiki/coremaster+12 -10
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jan 30 2016, 9:15 AM
Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added a project: MediaWiki-Patrolling.
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2016, 9:15 AM
Legoktm claimed this task.Feb 16 2016, 11:24 PM

I believe this is a regression from rMWc53f647658ad: Allow patrol of uploads. And it's bugging me a lot.

gerritbot subscribed.Feb 16 2016, 11:29 PM

Change 271148 had a related patch set uploaded (by Legoktm):
Don't show patrol links if RCP/NPP are disabled, but file patrol isn't

https://gerrit.wikimedia.org/r/271148

gerritbot added a project: Patch-For-Review.Feb 16 2016, 11:29 PM
Aklapper added a project: Regression.Feb 17 2016, 10:32 AM
Cenarium merged a task: T126184: Patrol links appear in Hungarian Wikipedia.Feb 17 2016, 2:19 PM
Cenarium added subscribers: Tgr, StudiesWorld.
matmarex mentioned this in T126184: Patrol links appear in Hungarian Wikipedia.Feb 17 2016, 2:24 PM
matmarex subscribed.
gerritbot added a comment.Feb 17 2016, 4:31 PM

Change 271148 merged by jenkins-bot:
Don't show patrol links if RCP/NPP are disabled, but file patrol isn't

https://gerrit.wikimedia.org/r/271148

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 18 2016, 12:01 AM
matmarex closed this task as Resolved.Feb 18 2016, 12:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits