Page MenuHomePhabricator

Patrol links show up even though patrolling is disabled on the wiki
Closed, ResolvedPublic

Description

I was browsing around officewiki and noticed a [Mark this page as patrolled] link. I clicked on it, and got a failure message. The API response was: "info": "Patrolling is disabled on this wiki".

So if that's the case...we shouldn't be showing the patrol links in the first place.

Event Timeline

Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added a project: MediaWiki-Patrolling.
Legoktm added a subscriber: Legoktm.

I believe this is a regression from rMWc53f647658ad: Allow patrol of uploads. And it's bugging me a lot.

Change 271148 had a related patch set uploaded (by Legoktm):
Don't show patrol links if RCP/NPP are disabled, but file patrol isn't

https://gerrit.wikimedia.org/r/271148

Change 271148 merged by jenkins-bot:
Don't show patrol links if RCP/NPP are disabled, but file patrol isn't

https://gerrit.wikimedia.org/r/271148