UNRECOVERABLE FATAL ERROR <<<
Maximum execution time of 10 seconds exceeded
/srv/phab/phabricator/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:264
┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
Description
Details
Event Timeline
Not sure what to say about that. The queries on that page are expensive, sometimes they will probably time out. It's sort of to be expected.
I guess we should file this upstream to see if any performance improvements can be done to it?
We should debug a bit ourselves first before potentially contacting upstream.
https://secure.phabricator.com/book/phabricator/article/performance/ for anyone interested.
We have php's maximum execution time set much lower than the default. I don't think that it would fail with the default 10 seconds.
@mmodell , i thought it was already 10 seconds?
What about increasing it to 15 or 20 seconds?
Change 335714 had a related patch set uploaded (by Paladox):
Up max_execution to 20 from 10 in phabricator/php.ini.erb
Change 335714 abandoned by Paladox:
Up max_execution to 15 from 10 in phabricator/php.ini.erb
https://phabricator.wikimedia.org/maniphest/report/project/ seems to work for me again. Not sure why.
Other queries such as https://phabricator.wikimedia.org/maniphest/report/?order=oldest-pri still sometimes do not work, sometimes they do.
It's because the report is very computationally expensive to generate, so it can only complete within the time limit when all of the circumstances align perfectly. This only works in the exceedingly rare event such as when the moon is full while simultaneously there is unusually little activity on all of phabricator's servers (web app + database).
This still appears to be an issue.
UNRECOVERABLE FATAL ERROR <<<
Maximum execution time of 10 seconds exceeded
/srv/deployment/phabricator/deployment-cache/revs/7dd45143c333b8fb854b8f40bd96c46ea56a0970/phabricator/src/applications/maniphest/controller/ManiphestReportController.php:528
┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
Is it at least possible to catch the exception and print that it's a pretty normal error, with a link to this task ?
Which problem would that solve which outweighs the costs for maintaining some custom patch to link to some custom bug report?
Change 410631 had a related patch set (by Paladox) published:
[operations/puppet@production] Phabricator: Raise php max_execution_time to 15
I've raised the timeout here ^^ hoping that will at least improve it some what, but this does seem very slow.
Timeout says it is on https://github.com/wikimedia/phabricator/blob/wmf/stable/src/infrastructure/edges/query/PhabricatorEdgeQuery.php#L257
@Paladox: Please read Chad's comment from 2017-02-06 on https://gerrit.wikimedia.org/r/#/c/335714/ again.
Ignoring feedback is not a good use of anybody else's time.
We increased the max_execution_time to 30s in https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/477595/ for php-fpm.
So once we switch to stretch we can switch on php-fpm and then it should work.