Page MenuHomePhabricator

Tab in tables in VisualEditor moves the wrong way in RTL
Closed, ResolvedPublic1 Estimated Story Points

Description

To reproduce:

  • Edit a page in the Hebrew Wikipedia in visual editor.
  • Add a table.
  • Single-click a cell in the middle of the table, and make it focused, but not editable.
  • Press tab.
    • As expected, the focus moves one cell forward, to the left (because we are in a right-to-left wiki).
  • Now double-click the same cell.
  • Press tab.

Expected: The focus must move to the left.
Observed: The focus moves to the right.

The same for Shift-Tab: It should move back (to the right), but it moves forward.

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added projects: VisualEditor, RTL.
Amire80 added subscribers: Amire80, YonaB, Mooeypoo.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Jdforrester-WMF edited projects, added VisualEditor-Tables; removed I18n.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.
Jdforrester-WMF added a subscriber: DLynch.

@dchan and I actually argued about this in https://gerrit.wikimedia.org/r/#/c/255160/5/src/ce/keydownhandlers/ve.ce.TableArrowKeyDownHandler.js when I was implementing it. The argument was that the current behavior is consistent with how the home / end keys behave in VE currently.

Jdforrester-WMF renamed this task from Tab in VisualEditor moves the wrong way in RTL to Tab in tables in VisualEditor moves the wrong way in RTL.Feb 4 2016, 7:08 PM

I think the issue is inconsistency between table selection and in-cell selection.

Change 268898 had a related patch set uploaded (by Esanders):
KeyDownHandlers: Make Tab behave the same in table cells as in table selections

https://gerrit.wikimedia.org/r/268898

Change 268898 merged by jenkins-bot:
KeyDownHandlers: Make Tab behave the same in table cells as in table selections

https://gerrit.wikimedia.org/r/268898