| Jdforrester-WMF | |
| Feb 1 2016, 4:36 PM |
| F9670210: Screen Shot 2017-09-20 at 13.32.51.png | |
| Sep 20 2017, 12:36 PM |
Example:
The dialogue in question says throughout that it's going to leave the feedback at VisualEditor/Feedback on wikidata.org, which doesn't exist. However, this is merely a display glitch, as the feedback is correctly posted on VisualEditor/Feedback on mediawiki.org as expected.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mw.Feedback: If the message is posted remotely, link the title correctly | mediawiki/core | master | +26 -5 |
Change 267696 had a related patch set uploaded (by Jforrester):
mw.Feedback: If the message is posted remotely, link the title correctly
Is this about https://phabricator.wikimedia.org/T92661#1986528, and does this mean I won't have to fix stuff manually? Thanks.
There are 2 issues I'm seeing,
I'm guessing the patch will mean both will be fixed.
I've updated this task to reflect the current state of affairs. As this is only a display glitch, I am decreasing priority.
This appears to be unrelated to this task. The feedback tool pastes the user agent of the user into the feedback, and that didn't happen here. I don't know how or why the user thought to leave that feedback there, but it wasn't through the visual editor itself, so it is outside the scope of this task.
@Deskana this is "just" patch to review IIUC, and I'm moving forward with the centralisation process (T162664) for which it will be useful. Currently the tool posts in the correct place, but does provide links (before and after using it) to a non-existent page in the main namespace, VisualEditor/Feedback. If the link at least pointed to WP:VisualEditor/Feedback instead (which exists on several projects, on most being a redirect), people wouldn't be entirely lost as to what happened to what they wrote (which obviously doesn't even show up in their local contribs).
@Esanders @DLynch @dchan Can we give the above patch a review? If it's almost there and we could give it a push over the finish line to make Erica's life a bit easier, that seems worth it. https://gerrit.wikimedia.org/r/#/c/267696/
The current patch is a bit broken/incomplete, but it's the right approach. I'll finish it up.
Change 267696 merged by jenkins-bot:
[mediawiki/core@master] mw.Feedback: If the message is posted remotely, link the title correctly