Page MenuHomePhabricator

WikidataPageBanner throwing exception on mobile diff page
Closed, ResolvedPublic

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_diff_test or any other page

Get error:
Exception encountered, of type "BadMethodCallException"
[8d2f50b3] /wiki/Selenium_diff_test BadMethodCallException from line 203 of /srv/mediawiki/php-master/extensions/WikidataPageBanner/includes/WikidataPageBanner.functions.php: Call to a member function transform() on a non-object (boolean)
Backtrace:
#0 /srv/mediawiki/php-master/extensions/WikidataPageBanner/includes/WikidataPageBanner.functions.php(223): WikidataPageBannerFunctions::getImageUrl(string, integer)
#1 /srv/mediawiki/php-master/extensions/WikidataPageBanner/includes/WikidataPageBanner.functions.php(142): WikidataPageBannerFunctions::getStandardSizeUrls(string)
#2 /srv/mediawiki/php-master/extensions/WikidataPageBanner/includes/WikidataPageBanner.hooks.php(129): WikidataPageBannerFunctions::getBannerHtml(string, array)
#3 /srv/mediawiki/php-master/includes/Hooks.php(195): WikidataPageBanner::onBeforePageDisplay(OutputPage, SkinMinervaBeta)
#4 /srv/mediawiki/php-master/includes/OutputPage.php(2318): Hooks::run(string, array)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(744): OutputPage->output()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(517): MediaWiki->main()
#7 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): include(string)
#9 {main}

Event Timeline

Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 267723 had a related patch set uploaded (by Jdlrobson):
Revert "Strict comparison for booleans"

https://gerrit.wikimedia.org/r/267723

Change 267723 merged by jenkins-bot:
Revert "Strict comparison for booleans"

https://gerrit.wikimedia.org/r/267723

Jdlrobson claimed this task.