Page MenuHomePhabricator

[Regression] Continuously getting an error about editing a old revision of the page with VE
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

I dont have exact steps to reproduce this but I am recently facing this a lot. Almost everytime I save an edit and reopen the page it tells me that I am trying to edit an old revision

Although I see a pattern here, not sure if thats reliable way to reproduce it but for everytime I save the page after adding an image or table and then reopen again to edit , it complains about that

Screen Shot 2016-02-01 at 9.36.02 PM.png (548×1 px, 152 KB)

Event Timeline

Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.

Yes got the Steps to reproduce:

  1. Open a page
  2. Add a focusable node such as cite note/image/link or add a numbered list
  3. Keep the focusable node highlighted/selcted

4.Click on Save page
5.Quickly click on Edit again to reopen the page (As soon as you see "Your edit was saved")

It complains that "You are editing a old revision of the page"

I'm seeing this today in Firefox 44. Rummana's steps to reproduce sound very plausible to me.

Getting this on en.wiki too now.

on mw.org (wmf.16 right now) for me it's simply:

  • Go to a page at rev0
  • Edit a page in VE, save it (rev1)
  • Keep that tab open, look at the page and see something else to edit
  • Click Edit again and VE loads the previous revision (rev0)

Change 276933 had a related patch set uploaded (by Alex Monk):
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId

https://gerrit.wikimedia.org/r/276933

Change 276933 merged by jenkins-bot:
In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId

https://gerrit.wikimedia.org/r/276933