Review and enhance the debug logging for SessionManager
Closed, ResolvedPublic
Actions

Description

Review the debug logging in the new SessionManager to ensure that it has proper levels and enough data to track down problems by correlating with other log sources in the event that problems are found.

Details

Related Gerrit Patches:

mediawiki/core : master

Update session log messages

Related Objects
Search...

Status	Assigned	Task
Resolved	Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved	Anomie	T32788 Allow triggering of user password reset email via the API
Open	None	T90925 General authentication improvements for MediaWiki
Resolved	Anomie	T48179 Allow a challenge stage during authentication
Open	None	T5709 Refactoring to make external authentication and identity systems easier
Resolved	Tgr	T43201 UserLoadFromSession considered evil
Resolved	Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	None	T55156 Provide option to force a login session to end within a certain time
Open	None	T89459 Modernize MediaWiki authentication system (AuthManager)
Resolved	Anomie	T123451 Deploy SessionManager and bot passwords
Resolved	• bd808	T125452 Review and enhance the debug logging for SessionManager

Event Timeline

• bd808 created this task.Feb 1 2016, 10:10 PM

• bd808 claimed this task.

• bd808 raised the priority of this task from to Needs Triage.

• bd808 updated the task description. (Show Details)

• bd808 added projects: Reading-Infrastructure-Team-Old (Don't use), MediaWiki-Authentication-and-authorization, MediaWiki-Debug-Logger.

• bd808 added subscribers: • bd808, Anomie, Tgr.

Restricted Application added a project: User-bd808. · View Herald TranscriptFeb 1 2016, 10:10 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

Currently 62 logger->* calls includes/session/*:

$ for l in debug info warning error; do echo $l; git grep "logger->$l" |awk '{print $1}'|sort|uniq -c; done
debug
   1 BotPasswordSessionProvider.php:
   2 CookieSessionProvider.php:
   2 ImmutableSessionProviderWithCookie.php:
  18 SessionBackend.php:
   8 SessionManager.php:
info
   4 BotPasswordSessionProvider.php:
   2 SessionManager.php:
warning
   6 PHPSessionHandler.php:
  15 SessionManager.php:
error
   4 SessionManager.php:

Change 268595 had a related patch set uploaded (by BryanDavis):
Update session log messages

https://gerrit.wikimedia.org/r/268595

gerritbot added a project: Patch-For-Review.Feb 4 2016, 11:39 PM

After my tweaks in https://gerrit.wikimedia.org/r/268595:

$ for l in debug info warning error; do echo $l; git grep "logger->$l" |awk '{print $1}'|sort|uniq -c; done
debug
   1 BotPasswordSessionProvider.php:
   2 CookieSessionProvider.php:
   2 ImmutableSessionProviderWithCookie.php:
  18 SessionBackend.php:
   9 SessionManager.php:
info
   4 BotPasswordSessionProvider.php:
   1 SessionManager.php:
warning
   3 CookieSessionProvider.php:
   6 PHPSessionHandler.php:
  15 SessionManager.php:
error
   4 SessionManager.php: