Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

Open a page in the visual editor.
Click "Cite".
Click the switch-to-wikitext button.
Save changes
See <ref /> in the wikitext.

Details

	Subject	Repo	Branch	Lines +/-
	DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface	mediawiki/extensions/VisualEditor	master	+2 -1

Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Feb 2 2016, 2:16 AM

• Whatamidoing-WMF raised the priority of this task from to Needs Triage.

• Whatamidoing-WMF updated the task description. (Show Details)

• Whatamidoing-WMF added projects: VisualEditor-EditingTools, Parsoid.

• Whatamidoing-WMF subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 2 2016, 2:16 AM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

Jdforrester-WMF renamed this task from Do not insert blank <ref>s to Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created.Feb 2 2016, 7:47 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Parsoid.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

you mean Keep changes?

@Esanders: I looked at this, and was tempted to try a this.getSurface().getModel().popAllStaging call before this.serialize in DesktopArticleTarget#switchToWikitextEditor - but then I looked into how the save dialog is opened... Would this be the right change to make? (in the editSource function)

-       this.getSurface().getDialogs().openWindow( 'wikitextswitchconfirm', { target: this } );
+       var windowAction = ve.ui.actionFactory.create( 'window', this.getSurface() );
+       windowAction.open( 'wikitextswitchconfirm', { target: this } );

Change 268857 had a related patch set uploaded (by Alex Monk):
DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface

https://gerrit.wikimedia.org/r/268857

gerritbot added a project: Patch-For-Review.Feb 6 2016, 2:04 AM

Change 268857 merged by jenkins-bot:
DesktopArticleTarget#editSource: Use actionFactory to create a window with the surface

https://gerrit.wikimedia.org/r/268857

Krenair closed this task as Resolved.Feb 7 2016, 1:41 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)); removed Patch-For-Review.Feb 8 2016, 3:42 AM

Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't createdClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Event Timeline

Back out pending nodes/etc. on switching editor so that e.g. half-made references aren't created
Closed, ResolvedPublic8 Estimated Story Points
Actions