Page MenuHomePhabricator

ContentTranslation builds fail because of missing UniversalLanguageSelector dependency
Closed, ResolvedPublic

Description

All ContentTranslation builds are failing because of a missing UniversalLanguageSelector dependency.

For example: https://gerrit.wikimedia.org/r/#/c/266705/

php55 is the failing part.

We have the dependencies defined in ext_dependencies.py AND in mediawiki-extensions.yaml, but apparently it isn't enough :)

Event Timeline

Amire80 created this task.Feb 2 2016, 9:19 AM
Amire80 raised the priority of this task from to Unbreak Now!.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, Legoktm, hashar, Nikerabbit.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2016, 9:19 AM
hashar added a comment.Feb 2 2016, 9:29 AM

On that change, a previous run of mwext-testextension-php53 had EXT_DEPENDENCIES set properly but the php55 one does not.

The root cause is Zuul can only invoke ONE parameter function for a job and the job would need two:

  • set PHP_BIN to switch to PHP5
  • set EXT_DEPENDENCIES

The root cause is CI config change https://gerrit.wikimedia.org/r/#/c/266039/ done as part of T119675: Adjust CI for PHP5.5 support it comes with:

+  - name: ^.*php55.*$
+    parameter-function: set_php_bin

Since it matches mwext-testextension-php55, that overrides the dependency injector :-/

Change 267856 had a related patch set uploaded (by Hashar):
test: there can be only one parameter function :/

https://gerrit.wikimedia.org/r/267856

Change 267856 abandoned by Hashar:
test: there can be only one parameter function :/

Reason:
Fails as expected with:

AssertionError: 'set_ext_dependencies' != 'set_php_bin' : Generic job mediawiki-extensions-php55 must have parameter function set_ext_dependencies

https://gerrit.wikimedia.org/r/267856

Change 267859 had a related patch set uploaded (by Hashar):
Revert all the php53/php55 recent additions

https://gerrit.wikimedia.org/r/267859

Change 267859 merged by jenkins-bot:
Revert all the php53/php55 recent additions

https://gerrit.wikimedia.org/r/267859

Amire80 moved this task from Needs Triage to CX8 on the ContentTranslation board.Feb 2 2016, 7:53 PM

Sorry about this :/

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 2 2018, 7:41 PM