Use a dedicated pool counter for the CompletionSuggester
Closed, ResolvedPublic
Actions

Description

The current implementation uses the Search pool counter.
We could use the Prefix pool counter but I'm not sure it will work well since we can run 2 queries in the same lock.
I don't know yet how to tune the values of this new pool counter, we could maybe start with 600 and monitor carefully what happens during spikes, compare the elastic threadpools queue and the poolcounter queue.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Create pool counter for CirrusSearch completion suggester	operations/mediawiki-config	master	+7 -0
	Use completion specific pool counter	mediawiki/extensions/CirrusSearch	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Deskana	T121616 EPIC: Resolve technical or product blockers to enable us to do a more full rollout of the completion suggester
		Resolved		EBernhardson	T125547 Use a dedicated pool counter for the CompletionSuggester

Event Timeline

dcausse created this task.Feb 2 2016, 6:09 PM

dcausse raised the priority of this task from to Needs Triage.

dcausse updated the task description. (Show Details)

dcausse added projects: CirrusSearch, Discovery-Search (Current work), OKR-Work.

dcausse subscribed.

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 2 2016, 6:09 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

dcausse added a parent task: T121616: EPIC: Resolve technical or product blockers to enable us to do a more full rollout of the completion suggester.Feb 2 2016, 6:10 PM

• ksmith moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Feb 2 2016, 9:20 PM

• Deskana triaged this task as Medium priority.Feb 2 2016, 11:04 PM

• Deskana subscribed.

EBernhardson claimed this task.Feb 3 2016, 12:52 AM

EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

EBernhardson set Security to None.

Change 268029 had a related patch set uploaded (by EBernhardson):
Create pool counter for CirrusSearch completion suggester

https://gerrit.wikimedia.org/r/268029

Change 268030 had a related patch set uploaded (by EBernhardson):
Use completion specific pool counter

https://gerrit.wikimedia.org/r/268030

Seems reasonable to start at 600. I do wonder if there should be some interaction between prefix search and completion search pool counters, although i've no clue how to implement it. Basically if the prefix and completion pool counters are full that could mean issues for the cluster. In theory that shouldn't happen, although only in theory :S

EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Feb 3 2016, 12:59 AM

Change 268030 merged by jenkins-bot:
Use completion specific pool counter

https://gerrit.wikimedia.org/r/268030

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 3 2016, 3:00 AM

• Deskana closed this task as Resolved.Feb 3 2016, 4:20 AM

• Deskana moved this task from Inbox to Scoring and result ordering on the CirrusSearch board.

• Deskana moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Feb 11 2016, 11:07 PM

Change 268029 merged by jenkins-bot:
Create pool counter for CirrusSearch completion suggester