Page MenuHomePhabricator

Use a dedicated pool counter for the CompletionSuggester
Closed, ResolvedPublic

Description

The current implementation uses the Search pool counter.
We could use the Prefix pool counter but I'm not sure it will work well since we can run 2 queries in the same lock.
I don't know yet how to tune the values of this new pool counter, we could maybe start with 600 and monitor carefully what happens during spikes, compare the elastic threadpools queue and the poolcounter queue.

Details

Related Gerrit Patches:
operations/mediawiki-config : masterCreate pool counter for CirrusSearch completion suggester
mediawiki/extensions/CirrusSearch : masterUse completion specific pool counter

Event Timeline

dcausse created this task.Feb 2 2016, 6:09 PM
dcausse raised the priority of this task from to Needs Triage.
dcausse updated the task description. (Show Details)
dcausse added a subscriber: dcausse.
Restricted Application added a project: Discovery. · View Herald TranscriptFeb 2 2016, 6:09 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Deskana triaged this task as Medium priority.Feb 2 2016, 11:04 PM
Deskana added a subscriber: Deskana.

Change 268029 had a related patch set uploaded (by EBernhardson):
Create pool counter for CirrusSearch completion suggester

https://gerrit.wikimedia.org/r/268029

Change 268030 had a related patch set uploaded (by EBernhardson):
Use completion specific pool counter

https://gerrit.wikimedia.org/r/268030

Seems reasonable to start at 600. I do wonder if there should be some interaction between prefix search and completion search pool counters, although i've no clue how to implement it. Basically if the prefix and completion pool counters are full that could mean issues for the cluster. In theory that shouldn't happen, although only in theory :S

Change 268030 merged by jenkins-bot:
Use completion specific pool counter

https://gerrit.wikimedia.org/r/268030

Deskana closed this task as Resolved.Feb 3 2016, 4:20 AM
Deskana moved this task from Uncategorised to Scoring and result ordering on the CirrusSearch board.

Change 268029 merged by jenkins-bot:
Create pool counter for CirrusSearch completion suggester

https://gerrit.wikimedia.org/r/268029