Have mediawiki-codesniffer linting on GWToolset
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JeanFred
	Feb 2 2016, 6:37 PM

Details

	Subject	Repo	Branch	Lines +/-
	Add PHP linting with mediawiki-codesniffer	mediawiki/extensions/GWToolset	master	+280 -240

Customize query in gerrit

Related Objects

Mentioned Here: rMWa49a8e7f0969: phpcs: Disable failing sniffs in phpcs.xml

Event Timeline

JeanFred created this task.Feb 2 2016, 6:37 PM

JeanFred raised the priority of this task from to Low.

JeanFred updated the task description. (Show Details)

JeanFred added projects: Commons, Multimedia, MediaWiki-extensions-GWToolset.

JeanFred added subscribers: Aklapper, Steinsplitter, JeanFred.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptFeb 2 2016, 6:37 PM

JeanFred moved this task from Backlog to Internals on the MediaWiki-extensions-GWToolset board.Feb 2 2016, 6:38 PM

First pass:

A TOTAL OF 113 ERRORS AND 118 WARNINGS WERE FOUND IN 33 FILES
PHPCBF CAN FIX 180 OF THESE SNIFF VIOLATIONS AUTOMATICALLY

Way to go... :)

\o/

I would suggest doing something like rMWa49a8e7f0969: phpcs: Disable failing sniffs in phpcs.xml, so you can begin enforcing the ones that do pass, and slowly re-enable rules after fixing them, which will prevent accidental regressions in other patches. :)

The Math extension's composer.json has an example of how you can set up phpcbf to automatically fix errors, which saves a lot of time.

Thanks for chiming in :)

Generic.Files.EndFileNewline.NotFound)
Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace)
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed)
MediaWiki.Usage.DirUsage.FunctionFound)
MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect)
MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment)
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis)
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis)
MediaWiki.WhiteSpace.SpaceyParenthesis.SpaceBeforeOpeningParenthesis)
PSR2.Classes.PropertyDeclaration.Underscore)
PSR2.ControlStructures.ElseIfDeclaration.NotAllowed)
PSR2.Methods.MethodDeclaration.AbstractAfterVisibility)
PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter)
PSR2.Namespaces.UseDeclaration.MultipleDeclarations)
PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse)
PSR2.Namespaces.UseDeclaration.SpaceAfterUse)
Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect)
Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore)
Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)

After auto-fixing using --report=diff & patch, I end up with the following 6:

Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace)
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed)
MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment)
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis)
MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis)
PSR2.Classes.PropertyDeclaration.Underscore)

I’ll shove the rest in exclude as you suggest. :)

Patch-For-Review at https://gerrit.wikimedia.org/r/#/c/270095/ (Gerrit-bot in holiday or I’m doing something wrong? o_O)

JeanFred added a project: Patch-For-Review.Feb 11 2016, 9:03 PM

JeanFred set Security to None.

Change 270095 had a related patch set uploaded (by Jean-Frédéric):
Add PHP linting with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/270095

Change 270095 merged by jenkins-bot:
Add PHP linting with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/270095