Page MenuHomePhabricator
Create Task
Maniphest T125655

VE QUnit tests fail on 1.27.0-wmf.12 branch due to Wikidata branch cut issue
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

James F. proposed a submodule bump of VisualEditor on the new wmf/1.27.0-wmf.12 branch https://gerrit.wikimedia.org/r/#/c/268019/ . The mediawiki-extensions-qunit Jenkins job fails with a bunch of Wikidata related errors.

https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/28839/consoleFull

Chromium 48.0.2564 (Ubuntu 0.0.0) wikibase.datamodel.Claim Constructor FAILED
	Expected number of assertions to be defined, but expect() was not called.
Chromium 48.0.2564 (Ubuntu 0.0.0) wikibase.datamodel.Claim setMainSnak() & getMainSnak() FAILED
	Expected number of assertions to be defined, but expect() was not called.
Chromium 48.0.2564 (Ubuntu 0.0.0) wikibase.datamodel.Claim setQualifiers() & getQualifiers() FAILED
	Expected number of assertions to be defined, but expect() was not called.
Chromium 48.0.2564 (Ubuntu 0.0.0) jquery.valueview.experts.GlobeCoordinateInput focus[instance without notifier] FAILED

etc.

505 out of 1588 test fail :(

Related Objects
Search...

Event Timeline

hashar created this task.Feb 3 2016, 12:38 PM
hashar claimed this task.
hashar raised the priority of this task from to Unbreak Now!.
hashar updated the task description. (Show Details)
hashar added projects: Release-Engineering-Team, MediaWiki-Core-Tests, Wikidata.
hashar added subscribers: thcipriani, • demon, • mmodell and 5 others.
Krenair subscribed.Feb 3 2016, 1:02 PM
hashar added a comment.Feb 3 2016, 1:02 PM

The change https://gerrit.wikimedia.org/r/#/c/268096/ pass QUnit. It is a dummy change made against mediawiki/core @wmf/1.27.0-wmf.12

Seems the qunit failures are related to the VisualEditor bump proposed with https://gerrit.wikimedia.org/r/#/c/268019/

Will remove Wikidata from project and add VisualEditor

hashar renamed this task from 30% of QUnit tests fail on 1.27.0-wmf.12 branch to 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump.Feb 3 2016, 1:03 PM
hashar edited projects, added VisualEditor; removed Wikidata.
hashar set Security to None.
hashar added a comment.Feb 3 2016, 1:57 PM

Looks like it was a one time error and then a racy test. The change landed.

hashar closed this task as Resolved.Feb 3 2016, 1:57 PM
Krenair added a comment.Feb 3 2016, 3:31 PM

Are you sure it wasn't just fixed by https://gerrit.wikimedia.org/r/#/c/267892/ ?

hashar reopened this task as Open.Feb 3 2016, 3:51 PM

Yeah the Wikidata bump might have fixed it.

There is still a racy test going on though:

00:03:28.636 Chromium 48.0.2564 (Ubuntu 0.0.0) mediawiki.jqueryMsg Match PHP parser FAILED
00:03:28.636 	Test timed out
00:03:28.636 	
00:03:28.636 	Language "zh" failed to load.
00:03:28.636 	Expected: true
00:03:28.636 	Actual: false
Paladox subscribed.Feb 3 2016, 3:52 PM

Should add the wikibase project since the errors says wikibase is the problem.

hashar renamed this task from 30% of QUnit tests fail on 1.27.0-wmf.12 branch when proposing a VE submodule dump to QUnit tests fail on 1.27.0-wmf.12 branch.Feb 3 2016, 3:56 PM
hashar added a comment.Feb 3 2016, 4:07 PM

The qunit reports a failure to get zh mediawiki.language.data and mediawiki.language over the API:

[proxy]: failed to proxy
     /jenkins-mediawiki-extensions-qunit-28918/load.php
          skin=fallback&lang=zh
          &debug=false
          &modules=mediawiki.language.data%7Cmediawiki.language
          &only=scripts
      (browser hung up the socket)

Happens at 15:46:07 UTC in https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/28918/consoleFull

We lack timestamp in the wfDebugLog that is capture with the build. It is rebuilding the cache for sure:

[MessageCache] MessageCache::load: Loading zh... local cache is empty, global cache is empty, loading from database
0.2854  25.0M  LocalisationCache::isExpired(zh): cache missing, need to make one
0.2949  25.2M  LocalisationCache::recache: got localisation for zh from source
0.8224  33.2M  LocalisationCache::isExpired(zh-hans): cache missing, need to make one
0.8244  33.2M  LocalisationCache::recache: got localisation for zh-hans from source

Maybe that timeout waiting for the cache to be populated. I have no idea what is the timeout value being used.

hashar added a subtask: T125484: [Regression] Random MediaWiki QUnit failure in CI: Language "zh" failed to load.Feb 3 2016, 4:12 PM
JanZerebecki closed this task as Resolved.Feb 3 2016, 4:13 PM
JanZerebecki subscribed.

Yea this happened because the fixes for T117886 weren't in that branch yet, because of T125663. I think the error from T125655#1994106 is unrelated and the same as T125484.

hashar mentioned this in T125484: [Regression] Random MediaWiki QUnit failure in CI: Language "zh" failed to load.Feb 3 2016, 4:19 PM
hashar added a comment.Feb 3 2016, 5:00 PM

Thank @JanZerebecki for the clarification.

Jdforrester-WMF renamed this task from QUnit tests fail on 1.27.0-wmf.12 branch to VE QUnit tests fail on 1.27.0-wmf.12 branch due to Wikidata branch cut issue.Feb 4 2016, 6:47 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).
Jdforrester-WMF edited a custom field.
JanZerebecki closed subtask T125484: [Regression] Random MediaWiki QUnit failure in CI: Language "zh" failed to load as Resolved.Feb 5 2016, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits