Page MenuHomePhabricator
Create Task
Maniphest T125672

Notice: Undefined variable: wgMFQueryPropModules in /srv/mediawiki/wmf-config/Wikibase.php on line 120
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

on beta, and will reach production unless fixed.

Feb 3 16:32:43 deployment-jobrunner01: #012Warning: in_array() expects parameter 2 to be an array or collection in /srv/mediawiki/wmf-config/Wikibase.php on line 120
Feb 3 16:32:44 deployment-jobrunner01: #012Notice: Undefined variable: wgMFQueryPropModules in /srv/mediawiki/wmf-config/Wikibase.php on line 120

Problem is that MobileFrontend now defines $wgMFQueryPropModules in extension.json, so the variable is no longer available at that point in configuration.

Details

SubjectRepoBranchLines +/-
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.phpoperations/mediawiki-configmaster+17 -6
Wikibase: Defer modifying wgMFQueryPropModules until wfLoadExtensions runsoperations/mediawiki-configmaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

aude created this task.Feb 3 2016, 4:36 PM
aude raised the priority of this task from to High.
aude updated the task description. (Show Details)
aude added a project: Wikidata.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2016, 4:36 PM
aude set Security to None.Feb 3 2016, 5:09 PM
aude added a subscriber: JanZerebecki.
gerritbot subscribed.Feb 3 2016, 6:18 PM

Change 268182 had a related patch set uploaded (by Aude):
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

gerritbot added a project: Patch-For-Review.Feb 3 2016, 6:18 PM
gerritbot added a comment.Feb 3 2016, 6:26 PM

Change 268147 had a related patch set uploaded (by BryanDavis):
Wikibase: Defer modifying wgMFQueryPropModules until wfLoadExtensions runs

https://gerrit.wikimedia.org/r/268147

gerritbot added a comment.Feb 3 2016, 6:40 PM

Change 268147 abandoned by BryanDavis:
Wikibase: Defer modifying wgMFQueryPropModules until wfLoadExtensions runs

Reason:
See I16e61d02c4f2cf827875ec9c59da2ce6064a0bd0 as a replacement.

https://gerrit.wikimedia.org/r/268147

bd808 added a project: Wikimedia-production-error.Feb 3 2016, 6:41 PM
bd808 subscribed.
JanZerebecki added a parent task: T125475: MW-1.27.0-wmf.12 deployment blockers.Feb 3 2016, 7:25 PM
greg subscribed.Feb 3 2016, 7:39 PM

status?

JanZerebecki added a comment.Feb 3 2016, 7:43 PM

I would expect this to be fixed once the above patch is deployed (needs to be done before the train).

gerritbot added a comment.Feb 3 2016, 7:47 PM

Change 268182 merged by jenkins-bot:
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

• demon closed this task as Resolved.Feb 3 2016, 7:49 PM
• demon claimed this task.
• demon reopened this task as Open.Feb 3 2016, 7:56 PM

Bleh, we swapped one undefined variable for another.

• demon closed this task as Resolved.Feb 3 2016, 7:59 PM

I lied. Touched InitialiseSettings again and we good.

• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Mar 11 2016, 11:57 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL