Page MenuHomePhabricator

Notice: Undefined variable: wgMFQueryPropModules in /srv/mediawiki/wmf-config/Wikibase.php on line 120
Closed, ResolvedPublicPRODUCTION ERROR

Description

on beta, and will reach production unless fixed.

Feb 3 16:32:43 deployment-jobrunner01: #012Warning: in_array() expects parameter 2 to be an array or collection in /srv/mediawiki/wmf-config/Wikibase.php on line 120
Feb 3 16:32:44 deployment-jobrunner01: #012Notice: Undefined variable: wgMFQueryPropModules in /srv/mediawiki/wmf-config/Wikibase.php on line 120

Problem is that MobileFrontend now defines $wgMFQueryPropModules in extension.json, so the variable is no longer available at that point in configuration.

Event Timeline

aude raised the priority of this task from to High.
aude updated the task description. (Show Details)
aude added a project: Wikidata.
aude added a subscriber: aude.
aude added a subscriber: JanZerebecki.

Change 268182 had a related patch set uploaded (by Aude):
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

Change 268147 had a related patch set uploaded (by BryanDavis):
Wikibase: Defer modifying wgMFQueryPropModules until wfLoadExtensions runs

https://gerrit.wikimedia.org/r/268147

Change 268147 abandoned by BryanDavis:
Wikibase: Defer modifying wgMFQueryPropModules until wfLoadExtensions runs

Reason:
See I16e61d02c4f2cf827875ec9c59da2ce6064a0bd0 as a replacement.

https://gerrit.wikimedia.org/r/268147

I would expect this to be fixed once the above patch is deployed (needs to be done before the train).

Change 268182 merged by jenkins-bot:
Put $wgMFQueryPropModules and $wgMFSearchApiModules in InitialiseSettings.php

https://gerrit.wikimedia.org/r/268182

demon claimed this task.

Bleh, we swapped one undefined variable for another.

I lied. Touched InitialiseSettings again and we good.

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM