Page MenuHomePhabricator

Wikidata broken on branch REL1_25 causing other extensions to fail.
Closed, ResolvedPublic

Description

Steps to Reproduce

Wikidata is causing other extensions to fail such as flow on the REL1_25 branch.

Actual results

It causes other extensions to fail on the REL1_25 branch so this needs fixing.

Expected results

  • The test should pass and not cause errors for other extensions.

Details

Related Gerrit Patches:

Event Timeline

Paladox created this task.Feb 3 2016, 10:03 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a subscriber: Paladox.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 3 2016, 10:03 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

@JanZerebecki can I add you to task please.

Paladox set Security to None.Feb 3 2016, 10:04 PM
Paladox removed a subscriber: JanZerebecki.

Scribunto also fails in test mwext-testextension-hhvm

https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/1290/console

22:21:14 There were 2 failures:
22:21:14
22:21:14 1) LuaSandbox: TextLibraryTests[85]: json decode, invalid values (trailing comma)
22:21:14 Failed asserting that two strings are identical.
22:21:14 --- Expected
22:21:14 +++ Actual
22:21:14 @@ @@
22:21:14 -ERROR: mw.text.jsonDecode: Syntax error
22:21:14 +{
22:21:14 + {
22:21:14 + ["x"] = 1,
22:21:14 + },
22:21:14 +}
22:21:14
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131
22:21:14
22:21:14 2) LuaStandalone: TextLibraryTests[85]: json decode, invalid values (trailing comma)
22:21:14 Failed asserting that two strings are identical.
22:21:14 --- Expected
22:21:14 +++ Actual
22:21:14 @@ @@
22:21:14 -ERROR: mw.text.jsonDecode: Syntax error
22:21:14 +{
22:21:14 + {
22:21:14 + ["x"] = 1,
22:21:14 + },
22:21:14 +}
22:21:14
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131

Change 268306 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

Anomie added a subscriber: Anomie.Feb 4 2016, 1:40 AM

Scribunto also fails in test mwext-testextension-hhvm

That's an upstream bug with HHVM, already tracked under T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma).

Anomie removed a subscriber: Anomie.

But why does it fail on REL1_25 branch but not on master branch.

Change 268473 had a related patch set uploaded (by Mattflaschen):
Temporarily skip a test that fails on HHVM.

https://gerrit.wikimedia.org/r/268473

But why does it fail on REL1_25 branch but not on master branch.

Probably because no one cherry-picked the workaround (to skip the test that triggers the HHVM bug). I've done that above.

Change 268473 merged by jenkins-bot:
Temporarily skip a test that fails on HHVM.

https://gerrit.wikimedia.org/r/268473

Change 268719 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268719

Change 268719 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268719

Change 268730 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268730

Change 268306 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
https://gerrit.wikimedia.org/r/#/c/268730/

https://gerrit.wikimedia.org/r/268306

Change 268730 abandoned by Mattflaschen:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
Duplicate of https://gerrit.wikimedia.org/r/#/c/268306/

https://gerrit.wikimedia.org/r/268730

Change 268306 restored by Mattflaschen:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

Change 268306 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

Change 268730 restored by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
This needs to be done because I accidentaly uploaded that one to master which caused it to fail Depend-On:.

https://gerrit.wikimedia.org/r/268730

Change 268825 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268825

Change 268827 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268827

Change 268730 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
https://gerrit.wikimedia.org/r/268827

https://gerrit.wikimedia.org/r/268730

Change 268828 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268828

Change 268827 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268827

Change 268825 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268825

Change 269310 had a related patch set uploaded (by Mattflaschen):
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/269310

Change 269310 merged by jenkins-bot:
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/269310

Change 268828 abandoned by Umherirrender:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
Superseeded by Ia0bdbe3978f6da1f1f51185563212132e101a00a

https://gerrit.wikimedia.org/r/268828

Change 277238 had a related patch set uploaded (by JanZerebecki):
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/277238

Change 277238 merged by JanZerebecki:
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/277238