Page MenuHomePhabricator
Create Task
Maniphest T125722

Wikidata broken on branch REL1_25 causing other extensions to fail.
Closed, ResolvedPublic
Actions

Description

Steps to Reproduce

Wikidata is causing other extensions to fail such as flow on the REL1_25 branch.

Actual results

It causes other extensions to fail on the REL1_25 branch so this needs fixing.

Expected results

  • The test should pass and not cause errors for other extensions.

Details

SubjectRepoBranchLines +/-
Disable unit tests and qunit testsmediawiki/extensions/WikidataREL1_26+6 -4
Disable unit tests and qunit testsmediawiki/extensions/WikidataREL1_25+8 -4
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/WikidataREL1_25+356 -29
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/Wikidatamaster+55 -25
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/WikidataREL1_25+42 -14
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/Wikidatamaster+55 -25
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/WikidataREL1_25+42 -14
Temporarily disable unit tests and autoloading autoload.php from composermediawiki/extensions/Wikidatamaster+13 -4
Temporarily skip a test that fails on HHVM.mediawiki/extensions/ScribuntoREL1_25+9 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Paladox created this task.Feb 3 2016, 10:03 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added projects: Wikidata, Continuous-Integration-Infrastructure, Continuous-Integration-Config, StructuredDiscussions.
Paladox subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 3 2016, 10:03 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Paladox added a subscriber: JanZerebecki.Feb 3 2016, 10:04 PM

@JanZerebecki can I add you to task please.

Paladox set Security to None.Feb 3 2016, 10:04 PM
Paladox removed a subscriber: JanZerebecki.
Paladox added a comment.Feb 3 2016, 10:23 PM

Scribunto also fails in test mwext-testextension-hhvm

https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/1290/console

22:21:14 There were 2 failures:
22:21:14
22:21:14 1) LuaSandbox: TextLibraryTests[85]: json decode, invalid values (trailing comma)
22:21:14 Failed asserting that two strings are identical.
22:21:14 --- Expected
22:21:14 +++ Actual
22:21:14 @@ @@
22:21:14 -ERROR: mw.text.jsonDecode: Syntax error
22:21:14 +{
22:21:14 + {
22:21:14 + ["x"] = 1,
22:21:14 + },
22:21:14 +}
22:21:14
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131
22:21:14
22:21:14 2) LuaStandalone: TextLibraryTests[85]: json decode, invalid values (trailing comma)
22:21:14 Failed asserting that two strings are identical.
22:21:14 --- Expected
22:21:14 +++ Actual
22:21:14 @@ @@
22:21:14 -ERROR: mw.text.jsonDecode: Syntax error
22:21:14 +{
22:21:14 + {
22:21:14 + ["x"] = 1,
22:21:14 + },
22:21:14 +}
22:21:14
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
22:21:14 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:131

Paladox added a project: Scribunto.Feb 3 2016, 10:23 PM
gerritbot subscribed.Feb 3 2016, 10:26 PM

Change 268306 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

gerritbot added a project: Patch-For-Review.Feb 3 2016, 10:26 PM
Anomie subscribed.Feb 4 2016, 1:40 AM
In T125722#1995833, @Paladox wrote:

Scribunto also fails in test mwext-testextension-hhvm

That's an upstream bug with HHVM, already tracked under T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma).

Anomie removed a project: Scribunto.Feb 4 2016, 1:41 AM
Anomie unsubscribed.
Paladox added a comment.Feb 4 2016, 8:35 AM

But why does it fail on REL1_25 branch but not on master branch.

gerritbot added a comment.Feb 4 2016, 8:43 PM

Change 268473 had a related patch set uploaded (by Mattflaschen):
Temporarily skip a test that fails on HHVM.

https://gerrit.wikimedia.org/r/268473

• Mattflaschen-WMF subscribed.Feb 4 2016, 8:46 PM
In T125722#1997021, @Paladox wrote:

But why does it fail on REL1_25 branch but not on master branch.

Probably because no one cherry-picked the workaround (to skip the test that triggers the HHVM bug). I've done that above.

Paladox added a comment.Feb 4 2016, 9:20 PM

Thanks.

gerritbot added a comment.Feb 5 2016, 1:50 PM

Change 268473 merged by jenkins-bot:
Temporarily skip a test that fails on HHVM.

https://gerrit.wikimedia.org/r/268473

gerritbot added a comment.Feb 5 2016, 6:57 PM

Change 268719 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268719

gerritbot added a comment.Feb 5 2016, 6:58 PM

Change 268719 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268719

gerritbot added a comment.Feb 5 2016, 8:14 PM

Change 268730 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268730

gerritbot added a comment.Feb 5 2016, 8:14 PM

Change 268306 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
https://gerrit.wikimedia.org/r/#/c/268730/

https://gerrit.wikimedia.org/r/268306

gerritbot added a comment.Feb 5 2016, 8:37 PM

Change 268730 abandoned by Mattflaschen:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
Duplicate of https://gerrit.wikimedia.org/r/#/c/268306/

https://gerrit.wikimedia.org/r/268730

gerritbot added a comment.Feb 5 2016, 8:37 PM

Change 268306 restored by Mattflaschen:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

gerritbot added a comment.Feb 5 2016, 8:44 PM

Change 268306 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268306

gerritbot added a comment.Feb 5 2016, 8:45 PM

Change 268730 restored by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
This needs to be done because I accidentaly uploaded that one to master which caused it to fail Depend-On:.

https://gerrit.wikimedia.org/r/268730

gerritbot added a comment.Feb 5 2016, 11:01 PM

Change 268825 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268825

gerritbot added a comment.Feb 5 2016, 11:02 PM

Change 268827 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268827

gerritbot added a comment.Feb 5 2016, 11:03 PM

Change 268730 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
https://gerrit.wikimedia.org/r/268827

https://gerrit.wikimedia.org/r/268730

gerritbot added a comment.Feb 5 2016, 11:03 PM

Change 268828 had a related patch set uploaded (by Paladox):
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268828

gerritbot added a comment.Feb 5 2016, 11:03 PM

Change 268827 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268827

gerritbot added a comment.Feb 5 2016, 11:07 PM

Change 268825 abandoned by Paladox:
Temporarily disable unit tests and autoloading autoload.php from composer

https://gerrit.wikimedia.org/r/268825

gerritbot added a comment.Feb 9 2016, 3:06 AM

Change 269310 had a related patch set uploaded (by Mattflaschen):
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/269310

gerritbot added a comment.Feb 13 2016, 10:28 AM

Change 269310 merged by jenkins-bot:
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/269310

JanZerebecki closed this task as Resolved.Feb 13 2016, 10:36 AM
JanZerebecki claimed this task.
JanZerebecki closed subtask T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail as Resolved.

See T126073#2025176

gerritbot added a comment.Feb 15 2016, 8:39 PM

Change 268828 abandoned by Umherirrender:
Temporarily disable unit tests and autoloading autoload.php from composer

Reason:
Superseeded by Ia0bdbe3978f6da1f1f51185563212132e101a00a

https://gerrit.wikimedia.org/r/268828

gerritbot added a comment.Mar 14 2016, 2:15 PM

Change 277238 had a related patch set uploaded (by JanZerebecki):
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/277238

gerritbot added a comment.Mar 14 2016, 2:44 PM

Change 277238 merged by JanZerebecki:
Disable unit tests and qunit tests

https://gerrit.wikimedia.org/r/277238

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL