PHP 5.5.9's getopt does not respect global $argv like HHVM does, causing issues parsing command line parameters via multiversion's MWScript.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krenair
	Feb 3 2016, 11:35 PM

Project Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Description

I was tracking down an issue that now appears to be separate in importImages (https://gerrit.wikimedia.org/r/#/c/268314/) while I stumbled into this weirdness through mcc.php. Wikimedia servers have been affected since https://gerrit.wikimedia.org/r/#/c/267816/

P2558 PHP script argument parsing wtf - HHVM 3.6.5 vs. PHP 5.5.9

1	krenair@terbium:~$ sudo -u www-data php "/srv/mediawiki/multiversion/MWScript.php" testP2557.php commonswiki --help
2	array(1) {
3	["help"]=>
4	bool(false)
5	}
6	array(3) {
7	[0]=>
8	string(13) "testP2557.php"
9	[1]=>
10	string(18) "--wiki=commonswiki"
11	[2]=>
12	string(6) "--help"
13	}
14	krenair@terbium:~$ sudo -u www-data php5 "/srv/mediawiki/multiversion/MWScript.php" testP2557.php commonswiki --help
15	array(0) {
16	}
17	array(3) {
18	[0]=>
19	string(13) "testP2557.php"
20	[1]=>
21	string(18) "--wiki=commonswiki"
22	[2]=>
23	string(6) "--help"
24	}
25	krenair@terbium:~$ php5 --version
26	PHP 5.5.9-1ubuntu4.14 (cli) (built: Oct 28 2015 01:34:46)
27	Copyright (c) 1997-2014 The PHP Group
28	Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
29	with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies
30	krenair@terbium:~$ php --version
31	HipHop VM 3.6.5 (rel)
32	Compiler: 1443697402_580739891
33	Repo schema: 10f852e58e0252284afc3158c4951c7db69aecd2
34	Extension API: 20150212
35	krenair@terbium:~$ cat /srv/mediawiki/php-1.27.0-wmf.10/maintenance/testP2557.php
36	<?php
37	//require_once __DIR__ . '/commandLine.inc';
38	$options = getopt( '', array( 'debug', 'help', 'cache:' ) );
39	var_dump( $options, $argv );

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Try to fix some other broken-looking legacy maintenance script options	Alex Monk	mediawiki/core	master	+15 -3

Customize query in gerrit

Related Objects

Mentioned In: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7)
T125540: New version of File:Duniya Na Mane, 1937.webm
Mentioned Here: P2558 PHP script argument parsing wtf - HHVM 3.6.5 vs. PHP 5.5.9

Event Timeline

Krenair created this task.Feb 3 2016, 11:35 PM

Krenair raised the priority of this task from to Needs Triage.

Krenair updated the task description. (Show Details)

Krenair added projects: MediaWiki-Maintenance-system, MediaWiki-General, SRE.

Krenair added subscribers: Krenair, Reedy, EBernhardson, yuvipanda.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 3 2016, 11:35 PM

Krenair added projects: Upstream, [DO NOT USE] NewPHP.Feb 3 2016, 11:36 PM

Krenair removed a project: [DO NOT USE] NewPHP.

Krenair set Security to None.

Docs for getopt say:

The parsing of options will end at the first non-option found, anything that follows is discarded.

So looks like PHP thinks testP2557.php is the first option. MWScript.php messes with $argv but I don't think PHP takes the data from this variable. From the code it looks like it uses $_SERVER['argv']. Also, looks like directly modifying it won't help much - it still uses the original value.

Ricordisamoa subscribed.Feb 4 2016, 9:39 AM

Krenair renamed this task from PHP 5.5.9 seems to have issues parsing some argumentless command line parameters to PHP 5.5.9 seems to have issues parsing some command line parameters via multiversion's MWScript.Feb 4 2016, 4:46 PM

krenair@terbium:~$ cat /srv/mediawiki/php-1.27.0-wmf.12/maintenance/testT125748.php
<?php
$options = getopt( '', array( 'help' ) );
var_dump( $options, $argv, $_SERVER["argv"] );
krenair@terbium:~$ sudo -u www-data php "/srv/mediawiki/multiversion/MWScript.php" testT125748.php commonswiki --help
array(1) {
  ["help"]=>
  bool(false)
}
array(3) {
  [0]=>
  string(15) "testT125748.php"
  [1]=>
  string(18) "--wiki=commonswiki"
  [2]=>
  string(6) "--help"
}
array(4) {
  [0]=>
  string(40) "/srv/mediawiki/multiversion/MWScript.php"
  [1]=>
  string(15) "testT125748.php"
  [2]=>
  string(11) "commonswiki"
  [3]=>
  string(6) "--help"
}
krenair@terbium:~$ sudo -u www-data php5 "/srv/mediawiki/multiversion/MWScript.php" testT125748.php commonswiki --help
array(0) {
}
array(3) {
  [0]=>
  string(15) "testT125748.php"
  [1]=>
  string(18) "--wiki=commonswiki"
  [2]=>
  string(6) "--help"
}
array(4) {
  [0]=>
  string(40) "/srv/mediawiki/multiversion/MWScript.php"
  [1]=>
  string(15) "testT125748.php"
  [2]=>
  string(11) "commonswiki"
  [3]=>
  string(6) "--help"
}

In T125748#1996646, @Smalyshev wrote:
Docs for getopt say:
The parsing of options will end at the first non-option found, anything that follows is discarded.
So looks like PHP thinks testP2557.php is the first option. MWScript.php messes with $argv but I don't think PHP takes the data from this variable. From the code it looks like it uses $_SERVER['argv']. Also, looks like directly modifying it won't help much - it still uses the original value.

But HHVM just appears to use the global argv... which is more useful, imo.

Krenair renamed this task from PHP 5.5.9 seems to have issues parsing some command line parameters via multiversion's MWScript to PHP 5.5.9's getopt does not respect global $argv like HHVM does, causing issues parsing command line parameters via multiversion's MWScript..Feb 4 2016, 5:15 PM

Krenair mentioned this in T125540: New version of File:Duniya Na Mane, 1937.webm.Feb 5 2016, 6:03 PM

Change 268328 had a related patch set uploaded (by Alex Monk):
Try to fix some other broken-looking legacy maintenance script options

https://gerrit.wikimedia.org/r/268328

gerritbot added a project: Patch-For-Review.Mar 12 2016, 12:35 AM

Change 268328 merged by jenkins-bot:
Try to fix some other broken-looking legacy maintenance script options

https://gerrit.wikimedia.org/r/268328

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)), MW-1.27-release-notes.Mar 18 2016, 10:00 PM

Krenair removed projects: Patch-For-Review, SRE.Apr 14 2016, 9:00 PM

hashar mentioned this in T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7).Sep 21 2016, 3:17 PM

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:44 PM

This was fixed by @Krenair by just not using getopt() anymore, which seems good enough to me. I confirmed that we're not using it, except in tests.

PHP 5.5.9's getopt does not respect global $argv like HHVM does, causing issues parsing command line parameters via multiversion's MWScript.Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

PHP 5.5.9's getopt does not respect global $argv like HHVM does, causing issues parsing command line parameters via multiversion's MWScript.
Closed, ResolvedPublic
Actions