Page MenuHomePhabricator
Create Task
Maniphest T125804

InstantCommons API requests to Commons are erroring out
Closed, ResolvedPublic
Actions

Description

In response for the request https://commons.wikimedia.org/w/api.php?titles=File%3ALambsdorf_Vladimir_%281844-1907%29.jpg&iiprop=url%7Cthumbnail%7Ctimestamp&iiurlwidth=300&iiurlheight=-1&iiurlparam=300px&prop=imageinfo&format=json&action=query&redirects=true&uselang=ru issued by MediaWiki 1.26.2 when trying to get thumbnail of an image hosted with WikiMedia Commons, Wikimedia Commons' API says: {"servedby":"mw1190","warnings":{"imageinfo":{"*":"Unrecognized value for parameter 'iiprop': thumbnail"}},"error":{"code":"iiurlparam","info":"Invalid value for iiurlparam (interlace=)","*":"See https://commons.wikimedia.org/w/api.php for API usage"}}.

As a result, there is a thumbnail creation error.

Details

SubjectRepoBranchLines +/-
BitmapHandler: Implement validateParam()mediawiki/corewmf/1.27.0-wmf.12+8 -0
BitmapHandler: Implement validateParam()mediawiki/coremaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

alex-mashin created this task.Feb 4 2016, 1:24 PM
alex-mashin raised the priority of this task from to Needs Triage.
alex-mashin updated the task description. (Show Details)
alex-mashin added projects: Commons, MediaWiki-Action-API.
alex-mashin subscribed.
Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald TranscriptFeb 4 2016, 1:24 PM
Anomie added subscribers: Anomie, Tgr, Unicornisaurous.Feb 4 2016, 2:26 PM

I note there has never been a thumbnail parameter for iiprop.

The Invalid value for iiurlparam (interlace=) is because JpegHandler::parseParamString() is returning "interlace" as false, but JpegHandler::validateParam() is rejecting it. This appears to have been caused by https://gerrit.wikimedia.org/r/#/c/264048/.

Anomie edited projects, added Multimedia, MediaWiki-File-management; removed MediaWiki-Action-API.Feb 4 2016, 2:26 PM
Anomie set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptFeb 4 2016, 2:26 PM
matmarex renamed this task from WikiMedia Commons broken (broken backward compability in API?) to InstantCommons API requests to Commons are erroring out.Feb 4 2016, 3:53 PM
matmarex merged tasks: T125799: InstantCommons completely broken, T125781: "Error generating thumbnail" for InstantCommons images.
matmarex added subscribers: Steinlaus, Nemo_bis.
Aklapper triaged this task as Unbreak Now! priority.Feb 4 2016, 3:55 PM
gerritbot subscribed.Feb 4 2016, 4:01 PM

Change 268404 had a related patch set uploaded (by Bartosz Dziewoński):
BitmapHandler: Implement validateParam()

https://gerrit.wikimedia.org/r/268404

gerritbot added a project: Patch-For-Review.Feb 4 2016, 4:01 PM
matmarex subscribed.Feb 4 2016, 4:05 PM

To be honest I don't really understand the code, but fix looks reasonable and fixes the issue locally for me.

matmarex claimed this task.Feb 4 2016, 4:05 PM
gerritbot added a comment.Feb 4 2016, 4:08 PM

Change 268404 merged by Bartosz Dziewoński:
BitmapHandler: Implement validateParam()

https://gerrit.wikimedia.org/r/268404

gerritbot added a comment.Feb 4 2016, 4:09 PM

Change 268407 had a related patch set uploaded (by Bartosz Dziewoński):
BitmapHandler: Implement validateParam()

https://gerrit.wikimedia.org/r/268407

gerritbot added a comment.Feb 4 2016, 4:41 PM

Change 268407 merged by jenkins-bot:
BitmapHandler: Implement validateParam()

https://gerrit.wikimedia.org/r/268407

matmarex closed this task as Resolved.Feb 4 2016, 4:55 PM

This has been fixed now, and the fix is deployed to Commons. InstantCommons on my local wiki works again.

matmarex added a comment.Feb 4 2016, 4:55 PM

Thanks for debugging, @Anomie and @alex-mashin :)

Unicornisaurous awarded a token.Feb 4 2016, 4:58 PM
matmarex added a comment.Feb 4 2016, 5:14 PM
In T125804#1997876, @Anomie wrote:

I note there has never been a thumbnail parameter for iiprop.

https://gerrit.wikimedia.org/r/268418

• MZMcBride subscribed.Feb 4 2016, 7:32 PM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)), MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Feb 8 2016, 6:02 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL