Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
Closed, InvalidPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Feb 4 2016, 7:43 PM

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Resolved		Krenair	T55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
Resolved		Krenair	T89060 VisualEditor is not the editor linked from the diff page
Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor
Open		None	T54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
Resolved		Krenair	T54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Invalid		Krinkle	T125864 Fix the broken JS getCookie() call, which sets a cookie not recognised by the server

Event Timeline

Jdforrester-WMF created this task.Feb 4 2016, 7:43 PM

Jdforrester-WMF assigned this task to Krenair.

Jdforrester-WMF raised the priority of this task from to High.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF added subscribers: Aklapper, Krenair, Jdforrester-WMF, Krinkle.

alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$ git grep getCookie
VisualEditor.hooks.php:                 return $req->getCookie(
alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$

That's not JS and it already sets the prefix properly...

Why would a function called getCookie be setting a cookie anyway?

Apparently Krinkle knows what this is about.

	private static function getUserEditor( User $user, WebRequest $req ) {
		if ( $user->isAnon() ) {
			return $req->getCookie(
				'VEE',
				'',
				User::getDefaultOption( 'visualeditor-editor' )
			);

I assumed the second parameter to WebRequest::getCookie() was default value. But it new way of setCookie() - which replaced the prefix parmaeter with an options array containing key prefix, never made it to getCookie() so this is already setting the prefix. Never mind :)

Fix the broken JS getCookie() call, which sets a cookie not recognised by the serverClosed, InvalidPublic1 Estimated Story PointsActions

Related ObjectsSearch...

Event Timeline

Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
Closed, InvalidPublic1 Estimated Story Points
Actions

Related Objects
Search...