Fix the broken JS getCookie() call, which sets a cookie not recognised by the server
Closed, InvalidPublic1 Story Points

Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$ git grep getCookie
VisualEditor.hooks.php:                 return $req->getCookie(
alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$

That's not JS and it already sets the prefix properly...

Why would a function called getCookie be setting a cookie anyway?

Krenair reassigned this task from Krenair to Krinkle.Feb 8 2016, 1:09 AM

Apparently Krinkle knows what this is about.

Krinkle closed this task as Invalid.Feb 9 2016, 7:16 PM
	private static function getUserEditor( User $user, WebRequest $req ) {
		if ( $user->isAnon() ) {
			return $req->getCookie(
				'VEE',
				'',
				User::getDefaultOption( 'visualeditor-editor' )
			);

I assumed the second parameter to WebRequest::getCookie() was default value. But it new way of setCookie() - which replaced the prefix parmaeter with an options array containing key prefix, never made it to getCookie() so this is already setting the prefix. Never mind :)