| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | Krenair | T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis | ||
| Invalid | Krinkle | T125864 Fix the broken JS getCookie() call, which sets a cookie not recognised by the server | ||
| · · · |
Event Timeline
Comment Actions
alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$ git grep getCookie VisualEditor.hooks.php: return $req->getCookie( alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (master)$
That's not JS and it already sets the prefix properly...
Why would a function called getCookie be setting a cookie anyway?
Comment Actions
private static function getUserEditor( User $user, WebRequest $req ) { if ( $user->isAnon() ) { return $req->getCookie( 'VEE', '', User::getDefaultOption( 'visualeditor-editor' ) );
I assumed the second parameter to WebRequest::getCookie() was default value. But it new way of setCookie() - which replaced the prefix parmaeter with an options array containing key prefix, never made it to getCookie() so this is already setting the prefix. Never mind :)