Page MenuHomePhabricator
Create Task
Maniphest T126027

ve.ui.FragmentInspector#getBodyHeight: Remove need for Chrome-specific hack on non-opaque elements
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (c0fbb063a)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.FragmentInspector: Remove unnecessary Chrome hackVisualEditor/VisualEditormaster+1 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Feb 5 2016, 6:36 PM
Jdforrester-WMF raised the priority of this task from to Low.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: Technical-Debt, VisualEditor, Browser-Support-Google-Chrome.
Jdforrester-WMF added subscribers: Catrope, Aklapper, Jdforrester-WMF.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Feb 5 2016, 6:59 PM
matmarex subscribed.Mar 7 2016, 10:07 PM

The hack comes from T74338: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector and might no longer be needed. First, it seems that we no longer have anything with partial opacity in any inspectors (in neither of the current two themes). But even when I tried setting some opacities and removing this hack nothing seemed amiss. And I just ran into a superficially similar issue that has been fixed in Blink (https://gerrit.wikimedia.org/r/275676).

SamanthaNguyen moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 3 2017, 10:01 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:11 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:53 PM
gerritbot added a comment.Nov 18 2019, 6:06 PM

Change 551597 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.FragmentInspector: Remove unnecessary Chrome hack

https://gerrit.wikimedia.org/r/551597

gerritbot added a project: Patch-For-Review.Nov 18 2019, 6:06 PM
gerritbot added a comment.Dec 13 2019, 5:11 PM

Change 551597 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.FragmentInspector: Remove unnecessary Chrome hack

https://gerrit.wikimedia.org/r/551597

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Dec 13 2019, 5:16 PM
matmarex moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
gerritbot added a comment.Dec 15 2019, 7:40 PM

Change 557636 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c0fbb063a)

https://gerrit.wikimedia.org/r/557636

gerritbot added a project: Patch-For-Review.Dec 15 2019, 7:40 PM
gerritbot added a comment.Dec 16 2019, 5:58 PM

Change 557636 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c0fbb063a)

https://gerrit.wikimedia.org/r/557636

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 16 2019, 6:00 PM
• ppelberg closed this task as Resolved.Dec 24 2019, 5:08 PM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL