Page MenuHomePhabricator
Create Task
Maniphest T126052

Cross-browser support for IE - JS fixes
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

This ticket is to fix some issues with IE(8) and JavaScript.

This story was originally part of https://phabricator.wikimedia.org/T125566 but we broke it out into two tasks.

Related Objects
Search...

Event Timeline

debt created this task.Feb 5 2016, 7:42 PM
debt raised the priority of this task from to Medium.
debt updated the task description. (Show Details)
debt added projects: Discovery-Portal-Sprint, Discovery-ARCHIVED.
debt added subscribers: debt, Jdrewniak, JGirault.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2016, 7:42 PM
debt assigned this task to Jdrewniak.Feb 5 2016, 7:42 PM
debt added a subtask: T125472: EPIC: Release to Production: Prominent Search Box with type-ahead (metadata/images in search results).
debt updated the task description. (Show Details)
debt set Security to None.
debt edited a custom field.
debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.
JGirault mentioned this in T125571: Language selection should use native selector on mobile.Feb 9 2016, 3:20 AM
Jdrewniak added a subtask: T125571: Language selection should use native selector on mobile.Feb 9 2016, 2:05 PM
debt moved this task from What's Next to To Discuss on the Discovery-Portal-Sprint board.Feb 9 2016, 7:42 PM
Jdrewniak added a comment.Feb 10 2016, 6:48 PM

though this ticket is blocked by T125571, I did catch one error that did fix the language picker in IE8.
@JGirault I'll note it here just in case we use the same method in the refactor.

https://github.com/wikimedia/wikimedia-portals/blob/search-box/dev/wikipedia.org/assets/js/wm-portal.js#L767

Should be

e.cancelBubble = true;
debt moved this task from Needs triage to UX on the Discovery-ARCHIVED board.Feb 15 2016, 9:50 PM
Jdrewniak moved this task from To Discuss to In Progress on the Discovery-Portal-Sprint board.Mar 2 2016, 10:40 PM
JGirault moved this task from In Progress to Done on the Discovery-Portal-Sprint board.Mar 9 2016, 4:27 AM
debt closed this task as Resolved.Mar 10 2016, 12:56 AM

Closing this - looking good!

debt closed subtask T125571: Language selection should use native selector on mobile as Resolved.Mar 10 2016, 12:57 AM
debt closed subtask T125472: EPIC: Release to Production: Prominent Search Box with type-ahead (metadata/images in search results) as Resolved.Mar 11 2016, 2:47 AM
debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Apr 7 2016, 3:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL