Page MenuHomePhabricator
Create Task
Maniphest T126091

Make it possible to register ResourceLoaderTestModules in extension.json
Closed, ResolvedPublic
Actions

Description

It'd be nice to shrink our *.hooks.php files by being able to move these generally static definitions into extension.json; see for example EventLogging, Sentry, VisualEditor, Citoid, TemplateData, …

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/NavigationTimingmaster+14 -18Replace use of deprecated ResourceLoaderTestModules hook
mediawiki/coremaster+119 -23resourceloader: Support TestModules registration via extension.json
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 5 2016, 11:31 PM
Jdforrester-WMF raised the priority of this task from to Low.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: MediaWiki-ResourceLoader, MediaWiki-Configuration.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2016, 11:31 PM
Jdforrester-WMF set Security to None.Feb 5 2016, 11:42 PM
Jdforrester-WMF added a subscriber: Legoktm.
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Feb 18 2016, 1:53 PM
Krinkle claimed this task.Jan 18 2019, 7:50 PM
Krinkle raised the priority of this task from Low to Medium.
Krinkle added a project: Performance-Team.
gerritbot added a subscriber: gerritbot.Jan 18 2019, 8:35 PM

Change 485247 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Support TestModules registration via extension.json

https://gerrit.wikimedia.org/r/485247

gerritbot added a project: Patch-For-Review.Jan 18 2019, 8:35 PM
Jdforrester-WMF added a parent task: T214211: Migrate all (static) uses of the deprecated ResourceLoaderTestModules hook to the QUnitTestModule extension.json attribute.Jan 18 2019, 10:28 PM
Krinkle moved this task from Inbox to Doing (old) on the Performance-Team board.Jan 22 2019, 8:46 PM
gerritbot added a comment.Jan 23 2019, 12:13 AM

Change 485981 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/NavigationTiming@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/485981

Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Jan 23 2019, 12:15 AM
Krinkle moved this task from Blocked (old) to Doing (old) on the Performance-Team board.Feb 4 2019, 10:31 PM
gerritbot added a comment.Feb 6 2019, 12:17 AM

Change 485247 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Support TestModules registration via extension.json

https://gerrit.wikimedia.org/r/485247

gerritbot added a comment.Feb 6 2019, 12:17 AM

Change 485981 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/485981

Jdforrester-WMF closed this task as Resolved.Feb 6 2019, 12:19 AM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.17; 2019-02-12); removed Patch-For-Review.
Krinkle mentioned this in T232875: The "ResourceLoaderTestModules" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet.Sep 13 2019, 5:58 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL