Page MenuHomePhabricator
Create Task
Maniphest T126114

Copied adjacent extension objects collapsed on save
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  • In VE, click on a map and Ctrl+C
  • click right after the map, and Ctrl+V
  • You should see two identical maps (you can edit the second one if you want)
  • Save
  • Observe that the second map dissappeared

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+35 -14Fix transclusion node cloneElement method
Customize query in gerrit

Related Objects

Event Timeline

Yurik created this task.Feb 6 2016, 12:52 PM
Yurik raised the priority of this task from to High.
Yurik updated the task description. (Show Details)
Yurik added a project: Maps (Kartographer).
Yurik added subscribers: Yurik, Esanders, MaxSem.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2016, 12:52 PM
Yurik moved this task from Unsorted to VisualEditor on the Maps (Kartographer) board.Feb 6 2016, 12:53 PM
Yurik added a project: Maps.Feb 7 2016, 5:00 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 7 2016, 5:00 PM
Esanders renamed this task from Copied map object disappears on save in VE to Copied adjacent extension objects collapsed on save.Feb 7 2016, 5:46 PM
Esanders claimed this task.
Esanders added a project: VisualEditor.
Esanders set Security to None.

This is because the 'about' attribute is also copied. Parsoid uses this to ignore siblings which are just part of the rendering. We fixed this for templates, but not extensions...

gerritbot added a subscriber: gerritbot.Feb 7 2016, 6:31 PM

Change 268966 had a related patch set uploaded (by Esanders):
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966

gerritbot added a project: Patch-For-Review.Feb 7 2016, 6:31 PM
Esanders added a comment.Feb 7 2016, 6:46 PM

or at least we did fix it for templates. Turns our you found a one year old regression: T126169

Yurik moved this task from All map-related tasks to Kartographer on the Maps board.Feb 7 2016, 9:57 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Feb 8 2016, 1:19 AM
gerritbot added a comment.Feb 8 2016, 3:53 PM

Change 268966 merged by jenkins-bot:
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966

Jdforrester-WMF closed this task as Resolved.Feb 8 2016, 4:44 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)); removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Esanders mentioned this in T134374: Adjacent pasted references getting about-merged.May 4 2016, 12:58 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL