Page MenuHomePhabricator

Copied adjacent extension objects collapsed on save
Closed, ResolvedPublic1 Story Points

Description

  • In VE, click on a map and Ctrl+C
  • click right after the map, and Ctrl+V
  • You should see two identical maps (you can edit the second one if you want)
  • Save
  • Observe that the second map dissappeared

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterFix transclusion node cloneElement method

Event Timeline

Yurik created this task.Feb 6 2016, 12:52 PM
Yurik raised the priority of this task from to High.
Yurik updated the task description. (Show Details)
Yurik added a project: Maps (Kartographer).
Yurik added subscribers: Yurik, Esanders, MaxSem.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2016, 12:52 PM
Yurik added a project: Maps.Feb 7 2016, 5:00 PM
Restricted Application added a project: Discovery. · View Herald TranscriptFeb 7 2016, 5:00 PM
Esanders renamed this task from Copied map object disappears on save in VE to Copied adjacent extension objects collapsed on save.Feb 7 2016, 5:46 PM
Esanders claimed this task.
Esanders added a project: VisualEditor.
Esanders set Security to None.

This is because the 'about' attribute is also copied. Parsoid uses this to ignore siblings which are just part of the rendering. We fixed this for templates, but not extensions...

Change 268966 had a related patch set uploaded (by Esanders):
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966

or at least we did fix it for templates. Turns our you found a one year old regression: T126169

Yurik moved this task from All map-related tasks to Kartographer on the Maps board.Feb 7 2016, 9:57 PM

Change 268966 merged by jenkins-bot:
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966