Page MenuHomePhabricator

Every click after the initial selection of a character set in WikiEditor contiguously loads the entire group at the end of the previous group
Closed, ResolvedPublic

Description

Reproduce:

  • Open editing session using WikiEditor
  • Select the Special characters tab
  • Scroll to and select the Greek character set on the left.
    • Note the set doesn't have enough characters in it to fill out the allocated area for characters to the right.
  • Select Greek again on the left.

The entire set of Greek characters is loaded again beginning at the end of the initial set first rendered and the same 'allocated area' is now maxed out causing a scroll to kick-in.

Every click on a Character set's label on the left [re]generates the entire character set at the end of the previous [entire] set on the right.


Event Timeline

GOIII raised the priority of this task from to Needs Triage.
GOIII updated the task description. (Show Details)
GOIII added a project: WikiEditor.
GOIII added subscribers: GOIII, Fomafix, TheDJ, Edokter.

Change 268935 had a related patch set uploaded (by Alex Monk):
Empty special character page before adding more characters to it

https://gerrit.wikimedia.org/r/268935

Change 268968 had a related patch set uploaded (by Gerrit Patch Uploader):
Remove deferLoad of the toolbar

https://gerrit.wikimedia.org/r/268968

GOIII set Security to None.

Change 268968 had a related patch set uploaded (by Gerrit Patch Uploader):
Remove deferLoad of the toolbar

https://gerrit.wikimedia.org/r/268968

Can we please get the latest patch merged sooner rather than later?

I'm betting it will go a long way in clearing up things like T119324 once and for all.

Change 268935 abandoned by Alex Monk:
Empty special character page before adding more characters to it

https://gerrit.wikimedia.org/r/268935

I hope to review this before the end of the week.

Change 272334 had a related patch set uploaded (by TheDJ):
Only load a page/booklet once

https://gerrit.wikimedia.org/r/272334

Right, while I agree that the loading gif's etc are not really necessary anymore, I disagree that the whole defer'ed loading is no longer required. I can perceivably see the difference on an older Windows machine I have, between deferred loading and non-deferred loading.

Although e8d37102 was a significant contributor to the slowness, it was mostly so because of it's constant value that makes it's impact so visible. But that doesn't mean the impact of loading all characters in one go, has since become insignificant to everyone.

P.S. the primary reason that the gif is not visible, is because all the actions happen in the same render step. If you put timeout wrappers around the various steps (to force them the browser into the next cycle), they do briefly show. Since they are however so shortly visible, it's more annoying than useful.

Change 272334 merged by jenkins-bot:
Only load a page/booklet once

https://gerrit.wikimedia.org/r/272334

Fomafix reassigned this task from Fomafix to TheDJ.
Fomafix triaged this task as Medium priority.
Fomafix removed a project: Patch-For-Review.