Page MenuHomePhabricator
Create Task
Maniphest T126145

When CustomEditor is used, the EditPage robot policy isn't loaded
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Split out from T125670:

Head item <meta name="robots" content="noindex,nofollow" /> is missing when Single-edit-tab feature is enabled. The meta robots noindex tag is no longer added because that is normally done by EditPage which doesn't get constructed at all when SET is enabled. (EditAction.php decides to create EditPage based on the CustomEditor hook).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move EditPage robot policy out into EditActionmediawiki/coremaster+2 -3
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
ResolvedKrenairT126145 When CustomEditor is used, the EditPage robot policy isn't loaded
· · ·

Event Timeline

Jdforrester-WMF created this task.Feb 7 2016, 1:21 AM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: Contributors-Team, MediaWiki-Page-editing, VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF added subscribers: Jdforrester-WMF, Krinkle.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 7 2016, 1:21 AM
gerritbot subscribed.Feb 7 2016, 1:22 AM

Change 268609 had a related patch set uploaded (by Jforrester):
Move EditPage robot policy out into EditAction

https://gerrit.wikimedia.org/r/268609

gerritbot added a project: Patch-For-Review.Feb 7 2016, 1:22 AM
Jdforrester-WMF added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Feb 7 2016, 1:22 AM
Jdforrester-WMF triaged this task as Medium priority.Feb 7 2016, 1:24 AM
Jdforrester-WMF mentioned this in T125670: VisualEditor SET doesn't set the <title> element.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Feb 9 2016, 12:28 AM

Change 268609 merged by jenkins-bot:
Move EditPage robot policy out into EditAction

https://gerrit.wikimedia.org/r/268609

Jdforrester-WMF closed this task as Resolved.Feb 9 2016, 12:50 AM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)); removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.27-release-notes.Feb 9 2016, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits