When extension https://www.mediawiki.org/wiki/Reading/Web/Projects/Related_pages turned on with Monobook skin, related pages covers left menu.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix RelatedPages placement in Monobook | mediawiki/extensions/RelatedArticles | master | +36 -25 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T126149 "Related pages" extension layout bug in Monobook | |||
| Invalid | None | T127006 Saving the CirrusSearch beta feature on a ruwiki doesn't work |
Event Timeline
Comment Actions
Now left menu covers the left suggestion http://i.imgur.com/32XTn14.png. I think it's worse than ever.
Comment Actions
Change 271580 had a related patch set uploaded (by Bmansurov):
Disable RelatedPages in monobook
Comment Actions
This sounds like a skin-specific hack. I've never heard of us doing such things for monobook before, am I wrong?
Comment Actions
The feature is experimental. Rather than pretending we are supporting Monobook in its developer it's better to be explicit we are not hence why on the patch I have suggested we disable this at the beta feature level.
It can easily be tweaked and fixed up later if we decide later to roll this out to all users.
Comment Actions
Disable RelatedPages in monobook
Wait WAT?
This extension, even with this bug, is still much better than its absence.
Comment Actions
@bmansurov I had a quick glance and it seems the Vector styles would remedy this problem - so maybe we should just make those the default rather than Vector only and make Minerva's skins override the defaults?
If we find supporting Monobook is more complicated then that we should probably disable it, but no qualms here from continuing support based on the fact Monobook and Vector styles in theory should be compatible. What do you think?
Comment Actions
Sounds good. Update: I've made the vector styles default, but because of differences in margins, etc. RelatedPages still didn't look right in monobook. That's why I've updated the patch to include monobook specific styles. @Jdlrobson, hope that's good enough for now. I know we wouldn't want to do so in the ideal world, but in this case the fix is trivial, thus I think it's OK to cater for monobook specifically.