Page MenuHomePhabricator
Create Task
Maniphest T126169

[regression] Adjacent copied inline template is destroyed by Parsoid
Closed, ResolvedPublic1 Story Points
Actions

Description

This is the issue with 'about' attributes not getting stripped on copy/paste. We fixed it about 2 years ago, but it regressed about a year ago...

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterFix transclusion node cloneElement method
VisualEditor/VisualEditor : mastercloneElements: Use the correct node type when cloning

Related Objects

Event Timeline

Esanders created this task.Feb 7 2016, 6:24 PM
Esanders claimed this task.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders added subscribers: Esanders, Catrope.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 7 2016, 6:24 PM
gerritbot added a subscriber: gerritbot.Feb 7 2016, 6:25 PM

Change 268963 had a related patch set uploaded (by Esanders):
cloneElements: Use the correct node type when cloning

https://gerrit.wikimedia.org/r/268963

gerritbot added a comment.Feb 7 2016, 6:31 PM

Change 268966 had a related patch set uploaded (by Esanders):
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966

Jdforrester-WMF triaged this task as High priority.Feb 8 2016, 1:18 AM
Jdforrester-WMF added projects: VisualEditor-CopyPaste, MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Feb 8 2016, 1:24 AM

Change 268963 merged by jenkins-bot:
cloneElements: Use the correct node type when cloning

https://gerrit.wikimedia.org/r/268963

gerritbot added a comment.Feb 8 2016, 3:53 PM

Change 268966 merged by jenkins-bot:
Fix transclusion node cloneElement method

https://gerrit.wikimedia.org/r/268966

Jdforrester-WMF closed this task as Resolved.Feb 8 2016, 4:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL