Page MenuHomePhabricator

FlaggedRevs: Unmarked content is shown to all users, if content is used by a template
Open, MediumPublic

Assigned To
None
Authored By
Luke081515
Feb 8 2016, 8:47 PM
Tokens
"Pirate Logo" token, awarded by Luke081515."The World Burns" token, awarded by MGChecker."The World Burns" token, awarded by Yellowcard."The World Burns" token, awarded by Morten_Haan.

Description

Example

  1. Create a template with some content: http://de.wikipedia.beta.wmflabs.org/w/index.php?title=Vorlage:TestSichtung&oldid=13027
  2. Now create different content: http://de.wikipedia.beta.wmflabs.org/wiki/Vorlage:TestSichtung
  3. Now mark everything after the first version as unmarked: http://de.wikipedia.beta.wmflabs.org/w/index.php?title=Vorlage:TestSichtung&action=history
  4. Create now a page, where this content is used by a template transclusion: http://de.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia:Hauptseite/Test&action=edit
  5. And now the bug: This page shows the unmarked content, instead of the latest stable version: http://de.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Hauptseite/Test

This is a problem, for example some pages at dewiki are configured with autoreview=sysop, so that content is only shown via a template to a user, if the content is reviewed. That was the intention, but since this bug, this is not possible.

Event Timeline

Luke081515 raised the priority of this task from to Needs Triage.
Luke081515 updated the task description. (Show Details)
Luke081515 added subscribers: Luke081515, Cenarium.
Yellowcard added a subscriber: Yellowcard.

This is a serious issue, please fix as soon as possible.

Does anybody know whether this is a regression? How much is this a privacy (?) concern?

This issue is still open and an extensive limitation of the FlaggedRevs. Is this going to be fixed in the foreseeable future?

Hi everyone. This bug negatively affects the German main page and is therefore to be considered important. Could please anyone have a look into this and at least rate the amount of necessary work to fix it?

This comes up in the German Wikipedia every now and then, currently again. At least a reaction would be fantastic.

Furthermore, it radically contradicts the principle of FlaggedRevs. A bug like this should have a much bigger priority in being fixed than it has currently.

Yellowcard raised the priority of this task from High to Unbreak Now!.Jul 29 2016, 2:26 PM

Yes, this is simply a malfunction in the core of the flagged revs. I put the priority up to "Unbreak Now!" for this reason.

Jdforrester-WMF lowered the priority of this task from Unbreak Now! to Medium.Jul 29 2016, 4:03 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Sorry, this is a fundamental limitation of FlaggedRevs (and it's one of many reasons why I discourage communities from using the software). It has been this way since the beginning, and I imagine it would take a great deal of work (many months) to fix.

I would encourage wikis with FlaggedRevs installed to consider carefully this limitation (and the several others) in how they use the FlaggedRevs feature, and check the impact of their configurations. In dewiki's specific case highlighted here, I would recommend protecting each of the templates used on the Main Page so that only sysops can edit them, which is how MediaWiki is designed to work.

FlaggedRevs is not under active development by the Wikimedia Foundation, only maintenance. It would be possible for someone to come up with changes to provide this feature, but there would be a huge learning curve. I'd be happy to give (e.g.) Wikimedia Germany pointers to get started if they wanted to attempt to take this on.

In dewiki's specific case highlighted here, I would recommend protecting each of the templates used on the Main Page so that only sysops can edit them, which is how MediaWiki is designed to work.

This isn't a solution, it's an unwanted regression of the mainpage workflow at dewiki. I don't understand how this extensions could be designed without a proper implementation for templates, because it really disrupts any usage of this extension. I don't understand how anyone could design this software in that way.

That's why I consider this as a bug, not as a feature request.

Sorry, this is a fundamental limitation of FlaggedRevs (and it's one of many reasons why I discourage communities from using the software). It has been this way since the beginning, and I imagine it would take a great deal of work (many months) to fix.

I would encourage wikis with FlaggedRevs installed to consider carefully this limitation (and the several others) in how they use the FlaggedRevs feature, and check the impact of their configurations. In dewiki's specific case highlighted here, I would recommend protecting each of the templates used on the Main Page so that only sysops can edit them, which is how MediaWiki is designed to work.

FlaggedRevs is not under active development by the Wikimedia Foundation, only maintenance. It would be possible for someone to come up with changes to provide this feature, but there would be a huge learning curve. I'd be happy to give (e.g.) Wikimedia Germany pointers to get started if they wanted to attempt to take this on.

@Jdforrester-WMF I'm confused. Isn't this code written to actually prevent this malfunction?