Page MenuHomePhabricator

As an iPad user, I should see lead images at a regular aspect ratio so that I can actually see the image
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem
We're maintaining a fixed height of the lead image on iPad, unlike in the various "preview" cards in Explore which maintain a 16:9 aspect ratio. This results in awkwardly short, but very, very wide lead images:

Screen Shot 2016-02-08 at 10.33.31 PM.png (2,048×1,536 px, 1 MB)

Solution

  • On the iPad article view, use the 16:9 aspect ratio for the lead image by default (when the contents pane is open)

iPad - Article - Contents rail - open (768×1,024 px, 392 KB)

  • On collapsing the contents pane:
    • For non-panoramic lead images (where width:height is less than 2:1) – the 16:9 aspect ratio crop for the lead image is maintained and 'pillarboxed' with gray right and left margins.

Note the image is fit-to-widthwith top and bottom of the image cropped. Face-detection still applies, and is vertical based detection.

iPad - Article - Contents rail - closed (768×1,024 px, 367 KB)

  • For panoramic images – the image is again centered but scaled to fit the height of the lead image with protruding left and right sides cropped.

Face-detection can still apply, but would be horizontal-based detection.

iPad - Article v4bii - Panorama Contents closed.png (768×1,024 px, 429 KB)

Event Timeline

• BGerstle-WMF raised the priority of this task from to Needs Triage.
• BGerstle-WMF updated the task description. (Show Details)
• BGerstle-WMF moved this task to Needs Triage on the Wikipedia-iOS-App board.
• BGerstle-WMF subscribed.

The only problem is that maintaining actual 16:9 could make this take up a lot of height. Take for example, this "preview" card in Explore which is implemented to maintain 16:9 (which might be too tall:

Screen Shot 2016-02-08 at 10.35.50 PM.png (2,048×1,536 px, 1 MB)

• JMinor set Security to None.
This comment was removed by RHo.
• Fjalapeno set the point value for this task to 5.Aug 4 2016, 5:59 PM

Merging in similar image scaling issue on iPhone.

• JMinor raised the priority of this task from Low to Medium.Aug 15 2016, 6:24 PM

@RHo I think we still need some side-margin on iPad otherwise portrait orientation images take up way too much vertical space...

enwiki > Color wheel

No margins:

Screen Shot 2016-08-15 at 3.39.18 PM.png (1,136×902 px, 936 KB)

Previously with image taking 50% of width when landscape:

Screen Shot 2016-08-15 at 3.51.50 PM.png (1,136×902 px, 582 KB)

I'd probably recommend making the image between, say 55 to 65 % of screen width when landscape on iPad.

Yeah, aesthetics aside, that a lot of vertical scrolling...

@Mhurd @JMinor @RHo I'd rather have the wider images to match the header (and the margin), even with the extra scrolling for tall images.

Simulator Screen Shot Aug 16, 2016, 6.19.08 AM.png (1,536×2,048 px, 857 KB)

Simulator Screen Shot Aug 16, 2016, 6.21.17 AM.png (1,536×2,048 px, 1 MB)

Either way, I realize this adjustment wasn't part of this ticket, so I've reverted the changes on the PR and filed a separate ticket here:

https://phabricator.wikimedia.org/T143087

Yes, this ticket is related only to setting the aspect ration for the lead image at the top of an article, so thanks @JoeWalsh for filing the separate ticket T143087: Investigate the use of Wider Images on iPad.

Will leave comments on that ticket for potential to allow different margins depending on the different aspect ratio of images.

LGTM on iPad Air 2 sim.

Example article with a panoramic lead image
Language: Test Wiki
Article: Page042

Open TOC
Simulator Screen Shot 17 Aug 2016, 10.30.55 PM.png (1,536×2,048 px, 442 KB)
Closed TOC
Simulator Screen Shot 17 Aug 2016, 10.30.57 PM.png (1,536×2,048 px, 526 KB)

Example article with non-panoramic lead image
Language: English
Article: Usain Bolt

Open TOC
Simulator Screen Shot 17 Aug 2016, 10.35.33 PM.png (1,536×2,048 px, 899 KB)
Closed TOC
Simulator Screen Shot 17 Aug 2016, 10.35.25 PM.png (1,536×2,048 px, 816 KB)

Apologies. Functionally tested fine but just noticed that the background color to the left and right of a non-panoramic image with TOC closed should be a lighter color #eaecf0 than the current darker gray shown.

iPad article mock with redlines (912×613 px, 462 KB)

Testing on iPad Air/iOS 9.3.4 and Wikipedia app 5.1.0 (912). Based on the examples provided this is fixed.