Page MenuHomePhabricator

Make the search icon not pixelated on the search button.
Closed, ResolvedPublic

Description

Search icon appears pixelated, especially on retina screens. We should either have retina and non-retina images or use an svg search icon. See mock for the pixelated icon.

Change2.png (258×260 px, 10 KB)

Event Timeline

MSyed assigned this task to Jdrewniak.
MSyed raised the priority of this task from to High.
MSyed updated the task description. (Show Details)
MSyed set Security to None.
MSyed added subscribers: MSyed, Ironholds, JGirault and 3 others.
MSyed removed a subscriber: Jdrewniak.
debt lowered the priority of this task from High to Medium.Feb 10 2016, 1:02 AM
debt moved this task from Backlog to To Discuss on the Discovery-Portal-Sprint board.

It's not SVG already? I thought we used SVG for all our UI elements.

SVG support starts at IE9. http://caniuse.com/#feat=svg
We could have tried fallbacks, but since we had the largest range of browsers to support (until we get a better estimate of the browser share and decide to drop older browsers), we thought CSS sprites were best for now (also leveraged the browser cache easily)

The CSS sprites we use generate a 1x, 1.5x and 2x version of each image, so once T125472 will be deployed, this won't be an issue.

This will be resolved with this released to production: https://phabricator.wikimedia.org/T125115. Closing this now.