Page MenuHomePhabricator

Add top Most Read items to the feed
Closed, ResolvedPublic

Description

Breaking out subtasks for this Epic.

This covers adding the top 5 items for the day to the feed as part of the daily pushed content (Featured Article, POTD).

Note that this card should not be a singleton.

See epic for mocks and links to Spike/WIP info.

Event Timeline

JMinor raised the priority of this task from to High.
JMinor updated the task description. (Show Details)

@Nirzar @JMinor design needs updating. "Top read on" should include something about the site, e.g. "Top read on en.wikipedia.org" or something. Otherwise, you get two "Top read on" sections w/o any way to discern which one belongs to a given site:

pasted_file (1×750 px, 203 KB)

Also, ideally the new "top read" section which is added after search site changes should go on top of everything else, IMO. I don't know how feasible that would be, but I'll see what I can do.

Agreed. "en.wikipedia.org" is not the most comprehensible labeling, but is okay if no alternative is available.

Ideally, we'd used the localized label, as we use in the language picker.

Top read on [French] Wikipedia
for [date]

should be able to do that. @Nirzar any objections?

@Nirzar - please review. The screenshots are from iPhone 6S+ 9.2.1 with 5.0.0 (707). 'Top read' is placed after 'Nearby places'.

@JMinor

  1. Notice that 'for' is omitted on the screenshot - is it ok?

Top read on [French] Wikipedia
for [date]

IMG_0075 (1).PNG (2×1 px, 301 KB)

IMG_0076.PNG (640×360 px, 84 KB)

  1. When I switched wiki lang - the another section 'Top read' was added for the selected language. The language specific 'Top read' did not go away when I returned to English.

Is it ok not being able to dismiss language specific 'Top read' ? Also, changing device language does not display 'Top read' for selected device language.

Etonkovidova raised the priority of this task from High to Needs Triage.Feb 19 2016, 12:52 AM

There seems to be an issue with section header icon. its blurred. maybe its an asset issue.

@JMinor
The other thing i was confused about was the position of this card. it currently shows all top read cards at bottom. i think it should be above random

@Etonkovidova the "for" text is intentionally omitted from the "More Top Read" list view. @Nirzar i used the existing "trending-mini" icon, so if it's too small you'll need to give me a new one. regarding sort order, yeah it should be above random, i can look into that quickly

@JMinor @BGerstle-WMF I thought Top read is part of time relevant cards. i.e. part of POTD, featured, mainpage

right now when I wake up and refresh the feed, I see featured article on top, I see POTD on top but I have to scroll through all my suggestions to reach top read which time sensitive. should it part of "time" group?

@Nirzar for issue with ordering lets use this ticket:

T127859