Remove magic number timeout if possible when lazy loading images
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jhernandez
	Feb 11 2016, 10:30 AM

Description

In https://gerrit.wikimedia.org/r/#/c/268185/ in Skin.js there is a setTimeout with 100 ms, that is because using requestAnimationFrame or setTimeout with a small delay (0, 10, etc) won't always trigger the CSS transition that fades the image in.

In chrome it is more blatant than in firefox for example, meaning that the transition won't get triggered with a small delay or raf.

Why is this happening? How do we get rid of the 100ms magic number? How do we reliably trigger the CSS transition when we want to?

Details

	Subject	Repo	Branch	Lines +/-
	Replace transition with animation	mediawiki/extensions/MobileFrontend	master	+21 -6
	Also fade out image container when image loads	mediawiki/extensions/MobileFrontend	master	+18 -16

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Resolved		dr0ptp4kt	T114542 Next Generation Content Loading and Routing, in Practice
Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
Duplicate		dr0ptp4kt	T120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
Resolved		Jdlrobson	T113066 [GOAL] Make Wikipedia more accessible to 2G connections
Resolved		Jdlrobson	T124390 [GOAL] Load images with care
Declined		BBlack	T127883 Enable lazy loaded images for 50% of users in production
Resolved		Jdlrobson	T126590 Deploy lazy images to Mobile web beta
Resolved		phuedx	T126592 Remove magic number timeout if possible when lazy loading images

Event Timeline

• Jhernandez created this task.Feb 11 2016, 10:30 AM

• Jhernandez raised the priority of this task from to Needs Triage.

• Jhernandez updated the task description. (Show Details)

• Jhernandez added a project: MobileFrontend.

• Jhernandez added a subscriber: Aklapper.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptFeb 11 2016, 10:30 AM

Change 269985 had a related patch set uploaded (by Phuedx):
Replace transition with animation

https://gerrit.wikimedia.org/r/269985

gerritbot added a project: Patch-For-Review.Feb 11 2016, 3:55 PM

Jdlrobson triaged this task as Medium priority.Feb 11 2016, 4:55 PM

Jdlrobson subscribed.

Change 269985 merged by jenkins-bot:
Replace transition with animation

https://gerrit.wikimedia.org/r/269985

Change 270259 had a related patch set uploaded (by Phuedx):
Also fade out image container when image loads

https://gerrit.wikimedia.org/r/270259

This was fixed by 269985.

Change 270259 merged by jenkins-bot:
Also fade out image container when image loads